Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Issue 315103004: Video Player: Supports bound arguments of wrap() util function (Closed)

Created:
6 years, 6 months ago by yoshiki
Modified:
6 years, 6 months ago
Reviewers:
hirono
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org
Visibility:
Public.

Description

Video Player: Supports bound arguments of wrap() util function And with this patch, the error detail is shown in case of error. BUG=355545 TEST=manually tested R=hirono@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275328

Patch Set 1 #

Patch Set 2 : . #

Total comments: 4

Patch Set 3 : Addressed the comments & Added missing wrap() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -14 lines) Patch
M ui/file_manager/video_player/js/error_util.js View 1 2 1 chunk +11 lines, -4 lines 0 comments Download
M ui/file_manager/video_player/js/video_player.js View 1 2 7 chunks +10 lines, -10 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
yoshiki
@hirono, PTAL. Thanks.
6 years, 6 months ago (2014-06-05 03:22:55 UTC) #1
hirono
https://codereview.chromium.org/315103004/diff/40001/ui/file_manager/video_player/js/error_util.js File ui/file_manager/video_player/js/error_util.js (right): https://codereview.chromium.org/315103004/diff/40001/ui/file_manager/video_player/js/error_util.js#newcode35 ui/file_manager/video_player/js/error_util.js:35: return function wrappedCallback(var_args) { The name of wrappedCallback is ...
6 years, 6 months ago (2014-06-05 08:47:42 UTC) #2
yoshiki
@hirono, PTAL again? Thanks. https://codereview.chromium.org/315103004/diff/40001/ui/file_manager/video_player/js/error_util.js File ui/file_manager/video_player/js/error_util.js (right): https://codereview.chromium.org/315103004/diff/40001/ui/file_manager/video_player/js/error_util.js#newcode35 ui/file_manager/video_player/js/error_util.js:35: return function wrappedCallback(var_args) { On ...
6 years, 6 months ago (2014-06-05 14:28:13 UTC) #3
hirono
Thank you. lgtm!
6 years, 6 months ago (2014-06-06 04:13:16 UTC) #4
yoshiki
The CQ bit was checked by yoshiki@chromium.org
6 years, 6 months ago (2014-06-06 04:19:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoshiki@chromium.org/315103004/50001
6 years, 6 months ago (2014-06-06 04:21:43 UTC) #6
yoshiki
6 years, 6 months ago (2014-06-06 04:56:41 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 manually as r275328 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698