Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 3151002: Refactor and correct IS_SPEC_OBJECT macro (bringing bleeding edge r5087 to 2.... (Closed)

Created:
10 years, 4 months ago by Rico
Modified:
9 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

Refactor and correct IS_SPEC_OBJECT macro (bringing bleeding edge r5087 to 2.2 branch) This needs to go to the 2.2 branch since the test expectations was updated (and upstreamed) to reflect that we no longer need special threatment of fast/dom/undetectable-document-all.html. This fixes issue 51646. Committed: http://code.google.com/p/v8/source/detail?r=5219

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+157 lines, -46 lines) Patch
M src/arm/codegen-arm.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/arm/codegen-arm.cc View 1 chunk +18 lines, -0 lines 0 comments Download
M src/arm/full-codegen-arm.cc View 1 chunk +19 lines, -0 lines 0 comments Download
M src/codegen.h View 2 chunks +1 line, -1 line 0 comments Download
M src/full-codegen.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/full-codegen.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/ia32/codegen-ia32.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/ia32/codegen-ia32.cc View 1 chunk +21 lines, -0 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 chunk +20 lines, -0 lines 0 comments Download
M src/macros.py View 1 chunk +2 lines, -1 line 0 comments Download
M src/mips/codegen-mips.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/mips/codegen-mips.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/runtime.js View 5 chunks +9 lines, -13 lines 0 comments Download
M src/v8natives.js View 15 chunks +16 lines, -30 lines 0 comments Download
M src/version.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/codegen-x64.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/x64/codegen-x64.cc View 1 chunk +19 lines, -0 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Rico
10 years, 4 months ago (2010-08-10 06:21:29 UTC) #1
Mads Ager (chromium)
10 years, 4 months ago (2010-08-10 06:37:34 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698