Issue 315093002: [NaCl SDK] Add support for ASAN, TSAN and valgrind to test_sdk.py

Issue 315093002: [NaCl SDK] Add support for ASAN, TSAN and valgrind to test_sdk.py (Closed)

Created:
6 years, 6 months ago by Sam Clegg

Modified:
6 years, 6 months ago

Reviewers:
binji

CC:
chromium-reviews, binji+watch_chromium.org, Sam Clegg

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[NaCl SDK] Add support for ASAN, TSAN and valgrind to test_sdk.py The plan is to enable these on a seperate test bot. R=binji

Patch Set 2 : #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+52 lines, -9 lines)			Patch
	M	native_client_sdk/src/build_tools/test_sdk.py	View	1	5 chunks	+51 lines, -8 lines	0 comments	Download
	M	native_client_sdk/src/tools/host_gcc.mk	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

binji

lgtm https://codereview.chromium.org/315093002/diff/1/native_client_sdk/src/build_tools/test_sdk.py File native_client_sdk/src/build_tools/test_sdk.py (right): https://codereview.chromium.org/315093002/diff/1/native_client_sdk/src/build_tools/test_sdk.py#newcode166 native_client_sdk/src/build_tools/test_sdk.py:166: parser.add_option('--sanitiser', include american spelling too? :) (it matches ...

6 years, 6 months ago (2014-06-04 23:28:10 UTC) #2

Sam Clegg

https://codereview.chromium.org/315093002/diff/1/native_client_sdk/src/build_tools/test_sdk.py File native_client_sdk/src/build_tools/test_sdk.py (right): https://codereview.chromium.org/315093002/diff/1/native_client_sdk/src/build_tools/test_sdk.py#newcode166 native_client_sdk/src/build_tools/test_sdk.py:166: parser.add_option('--sanitiser', On 2014/06/04 23:28:10, binji wrote: > include american ...

6 years, 6 months ago (2014-06-04 23:46:15 UTC) #3

Message was sent while issue was closed.

Committed as r275199

Expand Messages | Collapse Messages