Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Unified Diff: slave/skia_slave_scripts/utils/force_update_checkout.py

Issue 315083006: Add GetRemoteMasterHash() function to git_utils.py. (Closed) Base URL: https://skia.googlesource.com/buildbot@master
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | slave/skia_slave_scripts/utils/git_utils.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: slave/skia_slave_scripts/utils/force_update_checkout.py
diff --git a/slave/skia_slave_scripts/utils/force_update_checkout.py b/slave/skia_slave_scripts/utils/force_update_checkout.py
index 8def961b8bb413c77944401e1b4e1be381264619..e5283a7028ea733d809009ba572835f94f65b6dc 100644
--- a/slave/skia_slave_scripts/utils/force_update_checkout.py
+++ b/slave/skia_slave_scripts/utils/force_update_checkout.py
@@ -18,8 +18,8 @@ sys.path.append(os.path.join(misc.BUILDBOT_PATH, 'site_config'))
sys.path.append(os.path.join(misc.BUILDBOT_PATH, 'third_party',
'chromium_buildbot', 'scripts'))
-from git_utils import GIT
import gclient_utils
+import git_utils
import shell_utils
import skia_vars
@@ -33,11 +33,7 @@ def force_update():
# Be sure that we sync to the most recent commit.
buildbot_revision = None
try:
- # TODO(borenet): Make this a function in git_utils. Something like,
- # "GetRemoteMasterHash"
- output = shell_utils.run([GIT, 'ls-remote',
- BUILDBOT_GIT_URL, '--verify',
- 'refs/heads/master'])
+ output = git_utils.GetRemoteMasterHash(BUILDBOT_GIT_URL)
if output:
buildbot_revision = shlex.split(output)[0]
except shell_utils.CommandFailedException:
« no previous file with comments | « no previous file | slave/skia_slave_scripts/utils/git_utils.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698