Issue 315073004: Remove volume level DCHECK in WebRtcAudioCapturer on CrOS

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 315073004: Remove volume level DCHECK in WebRtcAudioCapturer on CrOS (Closed)

Created:
6 years, 6 months ago by Pawel Osciak

Modified:
6 years, 6 months ago

Reviewers:
dgreid, wuchengli, scherkus (not reviewing)

CC:
chromium-reviews, fischman+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove volume level DCHECK in WebRtcAudioCapturer on CrOS As per discussion in the associated bug, this DCHECK may not make sense on CrOS. BUG=chrome-os-partner:29388 TEST=Run Debug Chrome, DCHECK not hit Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275392

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	content/renderer/media/webrtc_audio_capturer.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/posciak@chromium.org/315073004/1

6 years, 6 months ago (2014-06-06 00:15:34 UTC) #4

Message was sent while issue was closed.

Change committed as 275392

Expand Messages | Collapse Messages