chrome/test/data/extensions/api_test/notifications/galore/app/main.js - Issue 315053006: Refactor Notifications Galore to simplify, amke more hackable and add 'recording'.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/extensions/api_test/notifications/galore/app/main.js

Issue 315053006: Refactor Notifications Galore to simplify, amke more hackable and add 'recording'. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: cr feedback Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/data/extensions/api_test/notifications/galore/app/images/stop.png ('k') | chrome/test/data/extensions/api_test/notifications/galore/app/style.css » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/extensions/api_test/notifications/galore/app/main.js

diff --git a/chrome/test/data/extensions/api_test/notifications/galore/app/main.js b/chrome/test/data/extensions/api_test/notifications/galore/app/main.js

index 6ec7c871460e537c2f5c5e67fc54186f30d2895f..b4d9ce29b6bfd45c145b91dd18224e6db2fabb00 100644

--- a/chrome/test/data/extensions/api_test/notifications/galore/app/main.js

+++ b/chrome/test/data/extensions/api_test/notifications/galore/app/main.js

@@ -2,9 +2,5 @@

// Use of this source code is governed by a BSD-style license that can be

// found in the LICENSE file.

-(function() {

- var controller = Galore.controller.create();

- var listener = controller.createWindow.bind(controller);

- chrome.app.runtime.onLaunched.addListener(listener);

- chrome.app.runtime.onRestarted.addListener(listener);

-}());

+chrome.app.runtime.onLaunched.addListener(createWindow);

+chrome.app.runtime.onRestarted.addListener(createWindow);