Refactor Notifications Galore to simplify, amke more hackable and add 'recording'.

Refactor Notifications Galore to simplify, amke more hackable and add 'recording'.

BUG=
R=dewittj@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276736

[Dmitry Titov, 2014-06-06 02:43:04]

Not for final review yet, WIP.

This is a simplified version that also has a recording functionality added. I
will make sure that recorder works correctly before next patch.

Please let me know what you think about general direction...

[dewittj, 2014-06-06 17:54:22]

looks fine, shipit

https://codereview.chromium.org/315053006/diff/1/chrome/test/data/extensions/...
File chrome/test/data/extensions/api_test/notifications/galore/app/controller.js
(right):

https://codereview.chromium.org/315053006/diff/1/chrome/test/data/extensions/...
chrome/test/data/extensions/api_test/notifications/galore/app/controller.js:196:
function createWebKitNotification(options) {
s/webkit/w3c/ or web

https://codereview.chromium.org/315053006/diff/1/chrome/test/data/extensions/...
chrome/test/data/extensions/api_test/notifications/galore/app/controller.js:202:
icon: iconUrl
add tag?

https://codereview.chromium.org/315053006/diff/1/chrome/test/data/extensions/...
File chrome/test/data/extensions/api_test/notifications/galore/app/style.css
(right):

https://codereview.chromium.org/315053006/diff/1/chrome/test/data/extensions/...
chrome/test/data/extensions/api_test/notifications/galore/app/style.css:47:
xborder: 1px solid white;
this looks like debug code

[Dmitry Titov, 2014-06-06 22:57:19]

Also, updated recorder so it actually works (including recording length/progress
on play and enable/disable buttons appropriately)
Updated visual style to be more 21st century...

https://codereview.chromium.org/315053006/diff/1/chrome/test/data/extensions/...
File chrome/test/data/extensions/api_test/notifications/galore/app/controller.js
(right):

https://codereview.chromium.org/315053006/diff/1/chrome/test/data/extensions/...
chrome/test/data/extensions/api_test/notifications/galore/app/controller.js:196:
function createWebKitNotification(options) {
On 2014/06/06 17:54:22, dewittj wrote:
> s/webkit/w3c/ or web

Done.

https://codereview.chromium.org/315053006/diff/1/chrome/test/data/extensions/...
chrome/test/data/extensions/api_test/notifications/galore/app/controller.js:202:
icon: iconUrl
On 2014/06/06 17:54:22, dewittj wrote:
> add tag?

Done.

We currently don't seem to catch/log any events from web notifications... Can be
added if anyone needs it...

https://codereview.chromium.org/315053006/diff/1/chrome/test/data/extensions/...
File chrome/test/data/extensions/api_test/notifications/galore/app/style.css
(right):

https://codereview.chromium.org/315053006/diff/1/chrome/test/data/extensions/...
chrome/test/data/extensions/api_test/notifications/galore/app/style.css:47:
xborder: 1px solid white;
On 2014/06/06 17:54:22, dewittj wrote:
> this looks like debug code

Done.

[Dmitry Titov, 2014-06-06 22:57:20]

Also, updated recorder so it actually works (including recording length/progress
on play and enable/disable buttons appropriately)
Updated visual style to be more 21st century...

[dewittj, 2014-06-06 23:02:18]

let's output events for webkit notifications; it'll be confusing for qa to get
events for some but not others

[Dmitry Titov, 2014-06-06 23:39:28]

Done. Also added recording of web notifications (was only recording rich ones
before)

[Dmitry Titov, 2014-06-06 23:58:33]

Fixed more (restart on warm background page) renamed the webkit -> web
PTAL

[dewittj, 2014-06-07 00:08:04]

pending comments now so I can comment on newest version afresh

https://codereview.chromium.org/315053006/diff/60001/chrome/test/data/extensi...
File chrome/test/data/extensions/api_test/notifications/galore/app/controller.js
(right):

https://codereview.chromium.org/315053006/diff/60001/chrome/test/data/extensi...
chrome/test/data/extensions/api_test/notifications/galore/app/controller.js:145:
function deleteNotificaitonForPlay(kind, id) {
spelling :)

[dewittj, 2014-06-10 17:10:20]

looks ok, a few comments and also I don't think we should check in those icons
to Chrome, since that implies a certain license for reuse.

https://codereview.chromium.org/315053006/diff/80001/chrome/test/data/extensi...
File chrome/test/data/extensions/api_test/notifications/galore/app/controller.js
(right):

https://codereview.chromium.org/315053006/diff/80001/chrome/test/data/extensi...
chrome/test/data/extensions/api_test/notifications/galore/app/controller.js:34:
function updateButtonsState() {
This function could use a comment with all its fancy string manipulation.

https://codereview.chromium.org/315053006/diff/80001/chrome/test/data/extensi...
chrome/test/data/extensions/api_test/notifications/galore/app/controller.js:137:
deleteNotificaitonForPlay(segment.kind, segment.id);
spelling

https://codereview.chromium.org/315053006/diff/80001/chrome/test/data/extensi...
chrome/test/data/extensions/api_test/notifications/galore/app/controller.js:145:
function deleteNotificaitonForPlay(kind, id) {
spelling

[Dmitry Titov, 2014-06-10 19:41:21]

On 2014/06/10 17:10:20, dewittj wrote:
> looks ok, a few comments and also I don't think we should check in those icons
> to Chrome, since that implies a certain license for reuse.

Replaced recorder images with 100% made by me from scratch (I'm hereby grant
their free usage to public).
Moved Google images back to server, added logic to download them into blobs.


https://codereview.chromium.org/315053006/diff/80001/chrome/test/data/extensi...
>
chrome/test/data/extensions/api_test/notifications/galore/app/controller.js:34:
> function updateButtonsState() {
> This function could use a comment with all its fancy string manipulation.

Added comments.

https://codereview.chromium.org/315053006/diff/80001/chrome/test/data/extensi...
>
chrome/test/data/extensions/api_test/notifications/galore/app/controller.js:137:
> deleteNotificaitonForPlay(segment.kind, segment.id);
> spelling

Done.

https://codereview.chromium.org/315053006/diff/80001/chrome/test/data/extensi...
>
chrome/test/data/extensions/api_test/notifications/galore/app/controller.js:145:
> function deleteNotificaitonForPlay(kind, id) {
> spelling

Done.

My plan is, upon this review completion, to "git cl dcommit" images first, then
land the rest (try bots and cq does not work with binary objects sit seems)

[dewittj, 2014-06-12 17:55:05]

lgtm

[Dmitry Titov, 2014-06-12 18:56:30]

Committed patchset #6 manually as r276736 (presubmit successful).