Add RELEASE_ASSERT for ensuring that we have no empty context to V8WrapperInstantiationScope.

Add RELEASE_ASSERT for ensuring that we have no empty context to V8WrapperInstantiationScope.

BUG=369451
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176002

[tasak, 2014-06-09 06:34:14]

Would you review this CL?

[haraken, 2014-06-09 06:47:03]

LGTM

https://codereview.chromium.org/315043007/diff/20001/Source/bindings/v8/V8DOM...
File Source/bindings/v8/V8DOMWrapper.h (right):

https://codereview.chromium.org/315043007/diff/20001/Source/bindings/v8/V8DOM...
Source/bindings/v8/V8DOMWrapper.h:153: // in the context currently entered. This
is wrong.

Would you update this FIXME to clarify why we have a RELEASE_ASSERT here?

[tasak, 2014-06-09 07:10:13]

On 2014/06/09 06:34:14, tasak wrote:
> Would you review this CL?

I'm sorry. I have to fix WebArrayBufferConverter.

[haraken, 2014-06-11 12:21:34]

On 2014/06/09 07:10:13, tasak wrote:
> On 2014/06/09 06:34:14, tasak wrote:
> > Would you review this CL?
> 
> I'm sorry. I have to fix WebArrayBufferConverter.

The WebArrayBufferConverter CL has landed, so now it should be safe to land this
CL.

[tasak, 2014-06-12 02:08:07]

Thank you for reviewing.

I merged https://codereview.chromium.org/329013002/.

https://codereview.chromium.org/315043007/diff/20001/Source/bindings/v8/V8DOM...
File Source/bindings/v8/V8DOMWrapper.h (right):

https://codereview.chromium.org/315043007/diff/20001/Source/bindings/v8/V8DOM...
Source/bindings/v8/V8DOMWrapper.h:153: // in the context currently entered. This
is wrong.
On 2014/06/09 06:47:03, haraken wrote:
> 
> Would you update this FIXME to clarify why we have a RELEASE_ASSERT here?
> 

Done.

[tasak, 2014-06-12 02:08:10]

The CQ bit was checked by tasak@google.com

[haraken, 2014-06-12 02:10:39]

still LGTM

[commit-bot: I haz the power, 2014-06-12 02:14:04]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tasak@google.com/315043007/60001

[commit-bot: I haz the power, 2014-06-12 03:48:21]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_blink_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/1...)
  mac_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/11149)
  win_blink_compile_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_compile_dbg/bu...)
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/11653)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/18997)

[commit-bot: I haz the power, 2014-06-12 07:12:49]

Change committed as 176002

[haraken, 2014-06-12 16:04:45]

On 2014/06/12 07:12:49, I haz the power (commit-bot) wrote:
> Change committed as 176002

abarth@: ^^^^ Now the empty creation context is completely gone :)

[abarth-chromium, 2014-06-13 04:31:36]

On 2014/06/12 at 16:04:45, haraken wrote:
> abarth@: ^^^^ Now the empty creation context is completely gone :)

Wow!  That's amazing.  <3