Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Issue 315033002: Support external startup data in V8. (Closed)

Created:
6 years, 6 months ago by vogelheim
Modified:
6 years, 6 months ago
CC:
v8-dev, Paweł Hajdan Jr.
Visibility:
Public.

Description

Support external startup data in V8. [Retry of crrev.com/293993021, which caused problems with 'ninja all' in Chromium. First patch set if a clean apply of crrev.com/293993021. Subsequent sets are the actual fix for that issue.] If the embedder chooses, the 'natives' (library sources) and the precompiled startup blob can be written to files during the build process and handed over to V8 at startup. The main purpose would be to reduce the size of the compiled binary for space constrained platforms. The build-time option is off by default. Nothing should change if it's not enabled. BUG= R=jochen@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21696

Patch Set 1 #

Patch Set 2 : Fix build issue by making sure the target is empty (as opposed to not the chain of depedencies) whe… #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1013 lines, -257 lines) Patch
M BUILD.gn View 4 chunks +9 lines, -1 line 0 comments Download
M build/features.gypi View 2 chunks +8 lines, -3 lines 0 comments Download
M include/v8.h View 1 chunk +18 lines, -0 lines 0 comments Download
M src/api.cc View 2 chunks +18 lines, -2 lines 0 comments Download
M src/d8.h View 2 chunks +5 lines, -1 line 0 comments Download
M src/d8.cc View 2 chunks +65 lines, -0 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/heap.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mksnapshot.cc View 5 chunks +59 lines, -12 lines 0 comments Download
M src/natives.h View 2 chunks +9 lines, -0 lines 0 comments Download
A src/natives-external.cc View 1 chunk +190 lines, -0 lines 0 comments Download
M src/serialize.h View 4 chunks +3 lines, -75 lines 0 comments Download
M src/serialize.cc View 3 chunks +1 line, -21 lines 0 comments Download
M src/snapshot.h View 2 chunks +7 lines, -10 lines 0 comments Download
M src/snapshot-common.cc View 3 chunks +13 lines, -52 lines 0 comments Download
A src/snapshot-external.cc View 1 chunk +140 lines, -0 lines 0 comments Download
A src/snapshot-source-sink.h View 1 chunk +88 lines, -0 lines 0 comments Download
A src/snapshot-source-sink.cc View 1 chunk +95 lines, -0 lines 0 comments Download
M test/cctest/test-serialize.cc View 3 chunks +56 lines, -39 lines 0 comments Download
A + tools/concatenate-files.py View 2 chunks +42 lines, -21 lines 0 comments Download
M tools/gyp/v8.gyp View 1 10 chunks +132 lines, -7 lines 0 comments Download
M tools/js2c.py View 8 chunks +52 lines, -10 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jochen (gone - plz use gerrit)
lgtm
6 years, 6 months ago (2014-06-05 07:21:56 UTC) #1
vogelheim
6 years, 6 months ago (2014-06-05 13:06:38 UTC) #2
Message was sent while issue was closed.
Committed patchset #2 manually as r21696 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698