Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Unified Diff: Source/bindings/templates/interface_base.cpp

Issue 31503002: IDL compiler: [ActivityLogging] for setters (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebased Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/templates/attributes.cpp ('k') | Source/bindings/tests/idls/TestObjectPython.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/templates/interface_base.cpp
diff --git a/Source/bindings/templates/interface_base.cpp b/Source/bindings/templates/interface_base.cpp
index 89100fdffda2d5f4064aeb81070da717d1cce9ea..283b8b582753c99e914685d251484e22634af289 100644
--- a/Source/bindings/templates/interface_base.cpp
+++ b/Source/bindings/templates/interface_base.cpp
@@ -67,6 +67,8 @@ template <typename T> void V8_USE(T) { }
{% endif %}
{{attribute_getter_callback(attribute, world_suffix)}}
{% endfor %}
+{# FIXME: merge these 2 for loops #}
+{% for world_suffix in attribute.world_suffixes %}
{% if attribute.has_setter %}
{% if not attribute.has_custom_setter %}
{{attribute_setter(attribute, world_suffix)}}
@@ -74,6 +76,7 @@ template <typename T> void V8_USE(T) { }
{{attribute_setter_callback(attribute, world_suffix)}}
{% endif %}
{% endfor %}
+{% endfor %}
} // namespace {{cpp_class_name}}V8Internal
{% block class_attributes %}{% endblock %}
« no previous file with comments | « Source/bindings/templates/attributes.cpp ('k') | Source/bindings/tests/idls/TestObjectPython.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698