IDL compiler: [ActivityLogging] for setters

Source/bindings/scripts/unstable/v8_attributes.py

Index: Source/bindings/scripts/unstable/v8_attributes.py
diff --git a/Source/bindings/scripts/unstable/v8_attributes.py b/Source/bindings/scripts/unstable/v8_attributes.py
index 5a830fddfba6852f2f8f7886775b547e7cc9abf6..c8d4bb29821c7f52ca764cce059f5c7796c54330 100644
--- a/Source/bindings/scripts/unstable/v8_attributes.py
+++ b/Source/bindings/scripts/unstable/v8_attributes.py
@@ -71,8 +71,11 @@ def generate_attribute_and_includes(interface, attribute):
     has_custom_getter = has_extended_attribute(attribute, ('Custom', 'CustomGetter'))
     has_custom_setter = not attribute.is_read_only and has_extended_attribute(attribute, ('Custom', 'CustomSetter'))
     do_generate_setter = not (attribute.is_read_only or has_custom_setter)  # FIXME: need to check [PutForwards], [Reflect], and [Replaceable]
+    includes = set()
     contents = {
         'access_control_list': access_control_list(attribute),
+        'activity_logging_getter': v8_utilities.has_activity_logging(attribute, includes, 'Getter'),  # [ActivityLogging]
+        'activity_logging_setter': v8_utilities.has_activity_logging(attribute, includes, 'Setter'),  # [ActivityLogging]

[haraken, 2013/10/21 03:32:53]

has_activity_logging => activity_logging_world_list ?
activity_logging_getter => activitiy_logging_world_list_for_getter ?
activity_logging_setter => activitiy_logging_world_list_for_setter ?

(I feel that has_xxx and is_xxx are methods that return true or false.)

[Nils Barth (inactive), 2013/10/21 03:42:28]

Done! (That's clearer.)

         'cached_attribute_validation_method': extended_attributes.get('CachedAttribute'),
         'conditional_string': v8_utilities.generate_conditional_string(attribute),
         'cpp_type': v8_types.cpp_type(idl_type),
@@ -96,7 +99,6 @@ def generate_attribute_and_includes(interface, attribute):
         'runtime_enabled_function_name': v8_utilities.runtime_enabled_function_name(attribute),  # [RuntimeEnabled]
         'world_suffixes': ['', 'ForMainWorld'] if 'PerWorldBindings' in extended_attributes else [''],  # [PerWorldBindings]
     }
-    includes = set()
     if not has_custom_getter:
         generate_getter(interface, attribute, contents, includes)
     if do_generate_setter:
@@ -150,7 +152,6 @@ def generate_getter(interface, attribute, contents, includes):
                              'bindings/v8/ExceptionState.h']))
 
     contents.update({
-        'activity_logging_getter': v8_utilities.has_activity_logging(attribute, includes, 'Getter'),  # [ActivityLogging]
         'is_check_security_for_node': is_check_security_for_node,
         'is_unforgeable': 'Unforgeable' in extended_attributes,
     })
@@ -209,9 +210,9 @@ def generate_setter(interface, attribute, contents, includes):
     else:
         cpp_value = 'cppValue'
     contents.update({
-        'v8_value_to_local_cpp_value': v8_types.v8_value_to_local_cpp_value(idl_type, attribute.extended_attributes, 'jsValue', 'cppValue', includes, 'info.GetIsolate()'),
         'cpp_setter': setter_expression(interface, attribute, contents),
         'enum_validation_expression': enum_validation_expression(idl_type),
+        'v8_value_to_local_cpp_value': v8_types.v8_value_to_local_cpp_value(idl_type, attribute.extended_attributes, 'jsValue', 'cppValue', includes, 'info.GetIsolate()'),
     })