Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 315013003: Use tests tag for Skia tools on Android. (Closed)

Created:
6 years, 6 months ago by scroggo
Modified:
6 years, 6 months ago
Reviewers:
djsollen
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Use tests tag for Skia tools on Android. When generating the makefiles for Skia testing tools on Android, use the tag 'tests' and do not use the tags 'optional' or 'eng'. Committed: https://skia.googlesource.com/skia/+/0ba5a4a3060e13f5513f26fcd0720cb2caa3810e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M platform_tools/android/bin/gyp_to_android.py View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
scroggo
6 years, 6 months ago (2014-06-04 14:40:49 UTC) #1
djsollen
lgtm
6 years, 6 months ago (2014-06-04 14:42:04 UTC) #2
scroggo
The CQ bit was checked by scroggo@google.com
6 years, 6 months ago (2014-06-04 14:50:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/scroggo@google.com/315013003/1
6 years, 6 months ago (2014-06-04 14:51:32 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-04 15:25:54 UTC) #5
Message was sent while issue was closed.
Change committed as 0ba5a4a3060e13f5513f26fcd0720cb2caa3810e

Powered by Google App Engine
This is Rietveld 408576698