Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 315003008: [DevTools] UI for network conditions emulation. (Closed)

Created:
6 years, 6 months ago by dgozman
Modified:
6 years, 6 months ago
Reviewers:
eustas, vsevik, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

[DevTools] UI for network conditions emulation. BUG=245436, 327641 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175963

Patch Set 1 #

Total comments: 2

Patch Set 2 : Throughput #

Patch Set 3 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+221 lines, -5 lines) Patch
M Source/devtools/front_end/ResponsiveDesignView.js View 1 3 chunks +33 lines, -2 lines 0 comments Download
M Source/devtools/front_end/elements/OverridesView.js View 1 2 chunks +38 lines, -1 line 0 comments Download
M Source/devtools/front_end/overrides.css View 1 4 chunks +27 lines, -1 line 0 comments Download
M Source/devtools/front_end/responsiveDesignView.css View 1 2 chunks +13 lines, -1 line 0 comments Download
M Source/devtools/front_end/sdk/OverridesSupport.js View 1 2 9 chunks +103 lines, -0 lines 2 comments Download
M Source/devtools/front_end/ui/SettingsUI.js View 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
dgozman
esutas@, vsevik@, could you please take a look? pfeldman@, FYI. Screenshots: http://pbrd.co/1i67LLx, http://pbrd.co/1i685do.
6 years, 6 months ago (2014-06-05 14:50:17 UTC) #1
eustas
looks good https://codereview.chromium.org/315003008/diff/1/Source/devtools/front_end/sdk/OverridesSupport.js File Source/devtools/front_end/sdk/OverridesSupport.js (right): https://codereview.chromium.org/315003008/diff/1/Source/devtools/front_end/sdk/OverridesSupport.js#newcode271 Source/devtools/front_end/sdk/OverridesSupport.js:271: * @param {string} value please specify return ...
6 years, 6 months ago (2014-06-05 15:06:50 UTC) #2
pfeldman
lgtm https://codereview.chromium.org/315003008/diff/1/Source/devtools/front_end/sdk/OverridesSupport.js File Source/devtools/front_end/sdk/OverridesSupport.js (right): https://codereview.chromium.org/315003008/diff/1/Source/devtools/front_end/sdk/OverridesSupport.js#newcode842 Source/devtools/front_end/sdk/OverridesSupport.js:842: networkOfflineDomains?
6 years, 6 months ago (2014-06-05 15:13:43 UTC) #3
dgozman
PTAL Screenshots: http://pbrd.co/1kODwO9, http://pbrd.co/1kODzJS.
6 years, 6 months ago (2014-06-11 13:17:45 UTC) #4
vsevik
lgtm https://chromiumcodereview.appspot.com/315003008/diff/30001/Source/devtools/front_end/sdk/OverridesSupport.js File Source/devtools/front_end/sdk/OverridesSupport.js (right): https://chromiumcodereview.appspot.com/315003008/diff/30001/Source/devtools/front_end/sdk/OverridesSupport.js#newcode476 Source/devtools/front_end/sdk/OverridesSupport.js:476: ["2 Mbps (802.11b)", 2048 * 1024 / 8] ...
6 years, 6 months ago (2014-06-11 14:53:20 UTC) #5
dgozman
https://chromiumcodereview.appspot.com/315003008/diff/30001/Source/devtools/front_end/sdk/OverridesSupport.js File Source/devtools/front_end/sdk/OverridesSupport.js (right): https://chromiumcodereview.appspot.com/315003008/diff/30001/Source/devtools/front_end/sdk/OverridesSupport.js#newcode476 Source/devtools/front_end/sdk/OverridesSupport.js:476: ["2 Mbps (802.11b)", 2048 * 1024 / 8] On ...
6 years, 6 months ago (2014-06-11 14:59:02 UTC) #6
dgozman
The CQ bit was checked by dgozman@chromium.org
6 years, 6 months ago (2014-06-11 14:59:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/315003008/30001
6 years, 6 months ago (2014-06-11 15:00:04 UTC) #8
commit-bot: I haz the power
6 years, 6 months ago (2014-06-11 16:04:50 UTC) #9
Message was sent while issue was closed. 
Change committed as 175963

Powered by Google App Engine
This is Rietveld 408576698