Source/bindings/modules/generated.gyp - Issue 315003004: IDL build: Split global object computation into core and modules

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/modules/generated.gyp

Issue 315003004: IDL build: Split global object computation into core and modules (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Move modules_global_objects to core/generated to eliminate circular dependency of GYP files Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/modules/generated.gyp

diff --git a/Source/bindings/modules/generated.gyp b/Source/bindings/modules/generated.gyp

index 349b2c507e9ca748527a3184397788f704c1846e..3f86e673e2dcfce72821a1c9119d34f146ef565a 100644

--- a/Source/bindings/modules/generated.gyp

+++ b/Source/bindings/modules/generated.gyp

@@ -137,8 +137,7 @@

'target_name': 'modules_global_constructors_idls',

'type': 'none',

'dependencies': [

- # FIXME: should be modules_global_objects http://crbug.com/358074

- '../generated.gyp:global_objects',

+ '../core/generated.gyp:modules_global_objects',

'actions': [{

'action_name': 'generate_modules_global_constructors_idls',

@@ -149,7 +148,7 @@

# which should not appear on global objects).

'<(modules_idl_files_list)',

'<@(modules_idl_files)',

- '<(bindings_output_dir)/GlobalObjects.pickle',

+ '<(bindings_modules_output_dir)/GlobalObjectsModules.pickle',

'outputs': [

'<@(modules_global_constructors_generated_idl_files)',

@@ -161,7 +160,7 @@

'--idl-files-list',

'<(modules_idl_files_list)',

'--global-objects-file',

- '<(bindings_output_dir)/GlobalObjects.pickle',

+ '<(bindings_modules_output_dir)/GlobalObjectsModules.pickle',

'--write-file-only-if-changed',

'<(write_file_only_if_changed)',

'--',

« no previous file with comments | « Source/bindings/idl.gypi ('k') | Source/bindings/modules/modules.gypi » ('j') | no next file with comments »