Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 315003003: Compilation API: next step of deprecations. (Closed)

Created:
6 years, 6 months ago by marja
Modified:
6 years, 6 months ago
Reviewers:
dcarney
CC:
v8-dev, Paweł Hajdan Jr.
Visibility:
Public.

Description

Compilation API: next step of deprecations. Remove deprecated functions and deprecated Script::GetId (which was supposed to be deprecated, but Chrome was using it). R=dcarney@chromium.org, svenpanne@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=21695

Patch Set 1 #

Patch Set 2 : fixing a comment too #

Patch Set 3 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -29 lines) Patch
M include/v8.h View 1 2 2 chunks +3 lines, -19 lines 0 comments Download
M test/cctest/test-api.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M test/cctest/test-cpu-profiler.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M test/cctest/test-debug.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-profile-generator.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
marja
svenpanne@, ptal
6 years, 6 months ago (2014-06-04 11:40:03 UTC) #1
marja
oops, svenpanne is ooo. dcarney, could you review?
6 years, 6 months ago (2014-06-05 08:08:56 UTC) #2
dcarney
lgtm
6 years, 6 months ago (2014-06-05 08:17:12 UTC) #3
marja
6 years, 6 months ago (2014-06-05 13:02:26 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r21695 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698