Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1019)

Issue 314983002: X87: Improve write barriers in optimized code. (Closed)

Created:
6 years, 6 months ago by Weiliang
Modified:
6 years, 6 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev, danno
Visibility:
Public.

Description

X87: Improve write barriers in optimized code. Port r21630 (a21ff10) Original commit message: Use a cheaper RecordWriteForMap() to update the write barrier for maps. And skip the value check in RecordWriteField() when we statically know that the value is in new space (and therefore has "pointers to here are interesting" flag set). BUG= R=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21668

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -43 lines) Patch
M src/x87/lithium-codegen-x87.cc View 3 chunks +7 lines, -11 lines 0 comments Download
M src/x87/macro-assembler-x87.h View 5 chunks +18 lines, -5 lines 0 comments Download
M src/x87/macro-assembler-x87.cc View 8 chunks +31 lines, -27 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Weiliang
6 years, 6 months ago (2014-06-04 09:13:26 UTC) #1
Benedikt Meurer
LGTM
6 years, 6 months ago (2014-06-04 09:23:37 UTC) #2
Weiliang
6 years, 6 months ago (2014-06-04 09:27:30 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r21668 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698