Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1280)

Unified Diff: src/objects-inl.h

Issue 314953006: Implement LookupIterator designed to replace LookupResult (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Adding to BUILD.gn Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/lookup.cc ('K') | « src/objects.cc ('k') | src/runtime.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/objects-inl.h
diff --git a/src/objects-inl.h b/src/objects-inl.h
index cd61ab52b92a657d66eaef1d2b759e3123584d0d..2bca797d18a8bc5d33c839e842a0474a33530dbc 100644
--- a/src/objects-inl.h
+++ b/src/objects-inl.h
@@ -29,6 +29,7 @@
#include "src/incremental-marking.h"
#include "src/transitions-inl.h"
#include "src/objects-visiting.h"
+#include "src/lookup.h"
namespace v8 {
namespace internal {
@@ -664,8 +665,7 @@ bool Object::IsJSObject() {
bool Object::IsJSProxy() {
if (!Object::IsHeapObject()) return false;
- InstanceType type = HeapObject::cast(this)->map()->instance_type();
- return FIRST_JS_PROXY_TYPE <= type && type <= LAST_JS_PROXY_TYPE;
+ return HeapObject::cast(this)->map()->IsJSProxyMap();
rossberg 2014/06/11 15:37:00 Why not make the same change to IsJSObject? (And p
Toon Verwaest 2014/06/11 17:32:18 I'll defer that for now, not really relevant for t
}
@@ -1053,8 +1053,8 @@ bool Object::HasSpecificClassOf(String* name) {
MaybeHandle<Object> Object::GetProperty(Handle<Object> object,
Handle<Name> name) {
- PropertyAttributes attributes;
- return GetPropertyWithReceiver(object, object, name, &attributes);
+ LookupIterator it(object, name);
+ return GetProperty(&it);
}
« src/lookup.cc ('K') | « src/objects.cc ('k') | src/runtime.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698