Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Unified Diff: src/ic.cc

Issue 314953006: Implement LookupIterator designed to replace LookupResult (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Adding to BUILD.gn Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/ic.h ('k') | src/json-stringifier.h » ('j') | src/lookup.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/ic.cc
diff --git a/src/ic.cc b/src/ic.cc
index 0544a5bf9b734b88ce19c8b906d690f115c71fce..f09af327a192fa7b7305928baa1a11b44642a047 100644
--- a/src/ic.cc
+++ b/src/ic.cc
@@ -625,17 +625,14 @@ MaybeHandle<Object> LoadIC::Load(Handle<Object> object, Handle<String> name) {
// Update inline cache and stub cache.
if (use_ic) UpdateCaches(&lookup, object, name);
- PropertyAttributes attr;
// Get the property.
+ LookupIterator it(object, name);
Handle<Object> result;
ASSIGN_RETURN_ON_EXCEPTION(
- isolate(),
- result,
- Object::GetProperty(object, object, &lookup, name, &attr),
- Object);
+ isolate(), result, Object::GetProperty(&it), Object);
// If the property is not present, check if we need to throw an exception.
if ((lookup.IsInterceptor() || lookup.IsHandler()) &&
- attr == ABSENT && IsUndeclaredGlobal(object)) {
+ !it.IsFound() && IsUndeclaredGlobal(object)) {
return ReferenceError("not_defined", name);
}
« no previous file with comments | « src/ic.h ('k') | src/json-stringifier.h » ('j') | src/lookup.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698