Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Unified Diff: Source/bindings/v8/ScriptPromiseTest.cpp

Issue 314953005: Add an ASSERT about cross-world wrapper leakage into ScriptValue (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/v8/ScriptPromiseTest.cpp
diff --git a/Source/bindings/v8/ScriptPromiseTest.cpp b/Source/bindings/v8/ScriptPromiseTest.cpp
index 817bcfc5cd8540df93ee0045399cb43c39719caa..618b38ea91b1b6ed89d2341cc4995d0c6a22b192 100644
--- a/Source/bindings/v8/ScriptPromiseTest.cpp
+++ b/Source/bindings/v8/ScriptPromiseTest.cpp
@@ -194,8 +194,8 @@ TEST_F(ScriptPromiseTest, castNonPromise)
String onFulfilled1, onFulfilled2, onRejected1, onRejected2;
ScriptValue value = ScriptValue(scriptState(), v8String(isolate(), "hello"));
- ScriptPromise promise1 = ScriptPromise::cast(ScriptValue(value));
- ScriptPromise promise2 = ScriptPromise::cast(ScriptValue(value));
+ ScriptPromise promise1 = ScriptPromise::cast(scriptState(), ScriptValue(value));
+ ScriptPromise promise2 = ScriptPromise::cast(scriptState(), ScriptValue(value));
promise1.then(Function::create(isolate(), &onFulfilled1), Function::create(isolate(), &onRejected1));
promise2.then(Function::create(isolate(), &onFulfilled2), Function::create(isolate(), &onRejected2));
@@ -224,7 +224,7 @@ TEST_F(ScriptPromiseTest, reject)
String onFulfilled, onRejected;
ScriptValue value = ScriptValue(scriptState(), v8String(isolate(), "hello"));
- ScriptPromise promise = ScriptPromise::reject(ScriptValue(value));
+ ScriptPromise promise = ScriptPromise::reject(scriptState(), ScriptValue(value));
promise.then(Function::create(isolate(), &onFulfilled), Function::create(isolate(), &onRejected));
ASSERT_FALSE(promise.isEmpty());

Powered by Google App Engine
This is Rietveld 408576698