Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(515)

Issue 314953002: Oilpan: Replace RefPtrs to Node and its subclasses in core/loader with Oilpan transition types. (Closed)

Created:
6 years, 6 months ago by tkent
Modified:
6 years, 6 months ago
CC:
blink-reviews, webcomponents-bugzilla_chromium.org, dglazkov+blink, blink-reviews-html_chromium.org, gavinp+loader_chromium.org, Nate Chapin
Visibility:
Public.

Description

Oilpan: Replace RefPtrs to Node and its subclasses in core/loader with Oilpan transition types. This CL makes DocumentWriter GarbageCollectedFinalized. BUG=357163 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175461

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -19 lines) Patch
M Source/core/html/imports/HTMLImportLoader.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/imports/HTMLImportLoader.cpp View 3 chunks +3 lines, -2 lines 0 comments Download
M Source/core/loader/DocumentLoader.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/loader/DocumentLoader.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/loader/DocumentWriter.h View 2 chunks +5 lines, -6 lines 0 comments Download
M Source/core/loader/DocumentWriter.cpp View 5 chunks +11 lines, -5 lines 0 comments Download
M Source/core/loader/NavigationScheduler.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
tkent
Please review this.
6 years, 6 months ago (2014-06-04 05:32:34 UTC) #1
haraken
LGTM
6 years, 6 months ago (2014-06-04 05:42:01 UTC) #2
Mads Ager (chromium)
lgtm2
6 years, 6 months ago (2014-06-04 06:26:08 UTC) #3
zerny-chromium
lgtm
6 years, 6 months ago (2014-06-04 06:54:43 UTC) #4
tkent
The CQ bit was checked by tkent@chromium.org
6 years, 6 months ago (2014-06-04 07:58:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/314953002/1
6 years, 6 months ago (2014-06-04 07:58:48 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-04 09:34:07 UTC) #7
Message was sent while issue was closed.
Change committed as 175461

Powered by Google App Engine
This is Rietveld 408576698