Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Issue 314943004: GC_TRACING dumps its result to stderr (Closed)

Created:
6 years, 6 months ago by kouhei (in TOK)
Modified:
6 years, 6 months ago
Reviewers:
haraken, oilpan-reviews
CC:
blink-reviews, kouhei+heap_chromium.org, Mads Ager (chromium)
Visibility:
Public.

Description

GC_TRACING dumps its result to stderr Before this patch, GC_TRACING dumped its result to stdout. This has caused all LayoutTests to fail. This patch changes dump output to stderr, so LayoutTest run is not affected. Unfortunately there is no trybot with ENABLE(GC_TRACING). NOTRY=true BUG=381038 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175560

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -12 lines) Patch
M Source/platform/heap/Heap.cpp View 4 chunks +12 lines, -12 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
kouhei (in TOK)
6 years, 6 months ago (2014-06-05 09:07:01 UTC) #1
haraken
LGTM
6 years, 6 months ago (2014-06-05 09:12:14 UTC) #2
kouhei (in TOK)
The CQ bit was checked by kouhei@chromium.org
6 years, 6 months ago (2014-06-05 09:14:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kouhei@chromium.org/314943004/1
6 years, 6 months ago (2014-06-05 09:15:03 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-05 11:29:23 UTC) #5
Message was sent while issue was closed.
Change committed as 175560

Powered by Google App Engine
This is Rietveld 408576698