Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Issue 314933004: Always process landmines, even if GYP_CHROMIUM_NO_ACTION is set (Closed)

Created:
6 years, 6 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 6 months ago
Reviewers:
Michael Achenbach
CC:
chromium-reviews
Visibility:
Public.

Description

Always process landmines, even if GYP_CHROMIUM_NO_ACTION is set R=machenbach@chromium.org BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274762

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M build/gyp_chromium View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jochen (gone - plz use gerrit)
6 years, 6 months ago (2014-06-04 11:03:44 UTC) #1
Michael Achenbach
lgtm
6 years, 6 months ago (2014-06-04 11:05:49 UTC) #2
jochen (gone - plz use gerrit)
6 years, 6 months ago (2014-06-04 11:06:13 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r274762 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698