Source/core/editing/VisiblePosition.cpp - Issue 314923003: Make SVG elements not to consider editable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/VisiblePosition.cpp

Issue 314923003: Make SVG elements not to consider editable. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/editing/VisiblePosition.cpp

diff --git a/Source/core/editing/VisiblePosition.cpp b/Source/core/editing/VisiblePosition.cpp

index 83d287b7ae5a15d71b25d9c1600ab7897aff0075..0fa09ed933fb52e2fc164b4e33f85e41b692eed6 100644

--- a/Source/core/editing/VisiblePosition.cpp

+++ b/Source/core/editing/VisiblePosition.cpp

@@ -94,7 +94,8 @@ VisiblePosition VisiblePosition::previous(EditingBoundaryCrossingRule rule) cons

return VisiblePosition();

VisiblePosition prev = VisiblePosition(pos, DOWNSTREAM);

- ASSERT(prev != *this);

+ if (prev == *this)

Yuta Kitamura 2014/06/05 09:17:13 I would like to understand how this could happen.

yosin_UTC9 2014/06/06 02:14:33 I updated description. When we hit assertion fail

+ return VisiblePosition();

#ifndef NDEBUG

// we should always be able to make the affinity DOWNSTREAM, because going previous from an

« no previous file with comments | « LayoutTests/editing/execCommand/format-block-with-uneditable-crash-2-expected.txt ('k') | no next file » | no next file with comments »