Issue 314923003: Make SVG elements not to consider editable.

Issue 314923003: Make SVG elements not to consider editable. (Closed)

Created:
6 years, 6 months ago by yosin_UTC9

Modified:
6 years, 6 months ago

Reviewers:
yoichio, Yuta Kitamura

CC:
blink-reviews

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Make SVG elements not to consider editable. This patch changes Position::isCandidate() and Position::isCandidate() not to return true for SVG elements except for rendered text, since we don't implement SVG editor yet. Note: Rendered text in SVG documents are represented by |Text| class and their renderer is |RenderSVGInlineText| derived from |RenderText| class. BUG=380043 TEST=LayoutTests/editing/execCommand/format-block-with-uneditable-crash-2.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175855

Patch Set 1 #

Total comments: 2

Patch Set 2 : 2014-06-06T11:10:51 #

Patch Set 3 : 2014-06-09T04:22:19 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -1 line)			Patch
A +	LayoutTests/editing/execCommand/format-block-with-uneditable-crash-2.html	View	1 2	2 chunks	+1 line, -2 lines	0 comments	Download
A +	LayoutTests/editing/execCommand/format-block-with-uneditable-crash-2-expected.txt	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
M	Source/core/dom/Position.cpp	View	1 2	1 chunk	+6 lines, -0 lines	0 comments	Download
M	Source/core/dom/PositionIterator.cpp	View	1 2	1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 10 (0 generated)

Expand Messages | Collapse Messages

yosin_UTC9

Could you review this patch? Thanks in advance. Note: blink_android_compile_dbg bot failure isn't related to ...

6 years, 6 months ago (2014-06-05 03:57:33 UTC) #1

Yuta Kitamura

https://codereview.chromium.org/314923003/diff/1/Source/core/editing/VisiblePosition.cpp File Source/core/editing/VisiblePosition.cpp (right): https://codereview.chromium.org/314923003/diff/1/Source/core/editing/VisiblePosition.cpp#newcode97 Source/core/editing/VisiblePosition.cpp:97: if (prev == *this) I would like to understand ...

6 years, 6 months ago (2014-06-05 09:17:13 UTC) #2

yosin_UTC9

PTAL - Update change description - Remove redundant "</embed>" from test case. https://codereview.chromium.org/314923003/diff/1/Source/core/editing/VisiblePosition.cpp File Source/core/editing/VisiblePosition.cpp ...

6 years, 6 months ago (2014-06-06 02:14:33 UTC) #3

Yuta Kitamura

I still don't get why this change is safe. The contract with previousVisuallyDistinctCandidate() is unclear. ...

6 years, 6 months ago (2014-06-09 04:27:20 UTC) #5

yosin_UTC9

PTAL This patch changes Position and PositionIterator to make SVG elements not to be "candidate", ...

6 years, 6 months ago (2014-06-09 08:01:11 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yosin@chromium.org/314923003/40001

6 years, 6 months ago (2014-06-10 04:47:56 UTC) #9

Message was sent while issue was closed.

Change committed as 175855

Expand Messages | Collapse Messages