[GOM] Improve the display of the roll information

Tools/GardeningServer/scripts/ui_unittests.js

Index: Tools/GardeningServer/scripts/ui_unittests.js
diff --git a/Tools/GardeningServer/scripts/ui_unittests.js b/Tools/GardeningServer/scripts/ui_unittests.js
index cb6849834a92736846a167008f158ecbbbfe61cd..38f84cf37e15426581b509a894cc8830710be9ec 100644
--- a/Tools/GardeningServer/scripts/ui_unittests.js
+++ b/Tools/GardeningServer/scripts/ui_unittests.js
@@ -223,5 +223,40 @@ asyncTest("TreeStatus", 2, function() {
     });
 });
 
+var currentRoll = {
+    "results": [
+        { "messages":[],"base_url":"svn://svn.chromium.org/chrome/trunk/src","subject":"Blink roll 540:550","closed":false,"issue":1000}

[ojan, 2014/06/05 00:54:48]

Nit: We're a little less consitent about the spaces here, but most places don't
put the space after the { and do put spaces after the commas and colons.

[Julien - ping for review, 2014/06/05 01:51:52]

Done.

+    ]
+};
+
+asyncTest("RevisionDetails", 2, function() {
+    var simulator = new NetworkSimulator();
+    simulator.json = function(url)
+    {
+        return Promise.resolve(currentRoll);
+    }
+    simulator.get = function (url)
+    {
+        return Promise.resolve("540");
+    }
+
+    model.state.resultsByBuilder = {
+        "Linux": {
+            "blink_revision": "554",
+        }
+    };
+    model.state.recentCommits = [
+    {
+        "revision": "555",
+    }];
+
+    var revisionDetails;
+    simulator.runTest(function() {
+        revisionDetails = ui.revisionDetails();
+    }).then(function() {
+        equal(revisionDetails.innerHTML, 'Latest revision processed by every bot: <details><summary><a href="http://src.chromium.org/viewvc/blink?view=rev&amp;revision=554">554<span id="revisionPopUp"><table><tr><td><a href="http://build.chromium.org/p/chromium.webkit/waterfall?builder=Linux">Linux</a></td><td>554</td></tr></table></span></a></summary><table><tr><td><a href="http://build.chromium.org/p/chromium.webkit/waterfall?builder=Linux">Linux</a></td><td>554</td></tr></table></details>, trunk is at <a href="http://src.chromium.org/viewvc/blink?view=rev&amp;revision=555">555</a><br>Last roll is to <a href="http://src.chromium.org/viewvc/blink?view=rev&amp;revision=540">540</a>, current autoroll <a href="https://codereview.chromium.org/1000">540:550</a>');

[ojan, 2014/06/05 00:54:48]

When I do innerHTML based tests, I usually format the string so that it's human
readable, e.g.

'Latest revision processed by every bot: ' +
    '<details>' +
        '<summary>' +
            '<a
href="http://src.chromium.org/viewvc/blink?view=rev&amp;revision=554">554' +
...

Alternately, instead of using innerHTML, I do:
var container = document.createElement('div');
container.innerHTML = revisionDetails.innerHTML;

var expectedUrls = [...];
var expectedLinkText = [...];
var links = container.querySelectorAll('a');
// Loop through links and verify the URLs and link text all match
// Verify anything else about the DOM that seems like valuable testing to you.

The advantage of the latter is that it makes it a bit easier to maintain, e.g.
if you just add a space or a comma or something you don't need to update this
test.

[Julien - ping for review, 2014/06/05 01:51:52]

As we will be changing the formatting and it has an importance, I took the
innerHTML approach with a better format for the expected result..

+        start();
+    });
+});
 
 })();