[GOM] Improve the display of the roll information

Tools/GardeningServer/scripts/ui.js

 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 333 matching lines @@
             $(this).removeClass('processing');
     },
     newId: function() {
         var id = 'status-content-' + ++this._currentId;
         this._unfinishedIds[id] = 1;
         return id;
     }
 });
 
 ui.revisionDetails = base.extends('span', {
+    updateUI: function() {
+        this.appendChild(document.createElement("br"));
+        this.appendChild(document.createTextNode('Last roll is to '));
+        this.appendChild(ui.createLinkNode(trac.changesetURL(this.lastRolledRevision), this.lastRolledRevision));
+        this.appendChild(document.createTextNode(', current autoroll '));
+        if (this.roll) {
+            var linkText = "" + this.roll.fromRevision + ":" + this.roll.toRevision;
+            this.appendChild(ui.createLinkNode(this.roll.url, linkText));
+            if (this.roll.isStopped)
+                this.appendChild(document.createTextNode(' (STOPPED) '));
+        } else {
+            this.appendChild(document.createTextNode(' None'));
+        }
+    },
     init: function() {
         var theSpan = this;
         theSpan.appendChild(document.createTextNode('Latest revision processed by every bot: '));
 
         var latestRevision = model.latestRevisionWithNoBuildersInFlight();
         var latestRevisions = model.latestRevisionByBuilder();
 
         // Get the list of builders sorted with the most recent one first.
         var builders = Object.keys(latestRevisions);
         builders.sort(function (a, b) { return parseInt(latestRevisions[b]) - parseInt(latestRevisions[a]);});
@@ skipping 36 matching lines @@
         $(summaryLinkNode).mouseout(function(ev) {
             if (!revisionsNode.open) {
                 $(revisionsPopUp).removeClass("active");
             }
         });
 
         var totRevision = model.latestRevision();
         theSpan.appendChild(document.createTextNode(', trunk is at '));
         theSpan.appendChild(ui.createLinkNode(trac.changesetURL(totRevision), totRevision));
 
-        checkout.lastBlinkRollRevision().then(function(revision) {
-            theSpan.appendChild(document.createTextNode(', last roll is to '));
-            theSpan.appendChild(ui.createLinkNode(trac.changesetURL(revision), revision));
-        }, function() {});
-
-        rollbot.fetchCurrentRoll().then(function(roll) {
-            theSpan.appendChild(document.createTextNode(', current autoroll '));
-            if (roll) {
-                var linkText = "" + roll.fromRevision + ":" + roll.toRevision;
-                theSpan.appendChild(ui.createLinkNode(roll.url, linkText));
-                if (roll.isStopped)
-                    theSpan.appendChild(document.createTextNode(' (STOPPED) '));
-            } else {
-                theSpan.appendChild(document.createTextNode(' None'));
-            }
+        Promise.all([ checkout.lastBlinkRollRevision(), rollbot.fetchCurrentRoll() ]).then(function(results) {

[ojan, 2014/06/05 00:54:48]

Nit: I don't know if we have an official style rule for this, but I think we
normally wouldn't put the spaces after/before the [ and ]. The other places we
do arrays we don't put the spaces.

[Julien - ping for review, 2014/06/05 01:51:52]

Done.

+            theSpan.lastRolledRevision = results[0];
+            theSpan.roll = results[1];
+            theSpan.updateUI();
         });
     }
 });
 
 })();