chrome/browser/printing/page_range_unittest.cc - Issue 3149: Porting changes in chrome/{browser,common}, also enabling more unit tests....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/printing/page_range_unittest.cc

Issue 3149: Porting changes in chrome/{browser,common}, also enabling more unit tests.... (Closed) Base URL: http://src.chromium.org/svn/trunk/src/

Patch Set: '' Created 12 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/printing/page_range_unittest.cc

===================================================================

--- chrome/browser/printing/page_range_unittest.cc (revision 2402)

+++ chrome/browser/printing/page_range_unittest.cc (working copy)

@@ -18,7 +18,7 @@

range.to = 5;

ranges.push_back(range);

std::vector<int> pages(printing::PageRange::GetPages(ranges));

- ASSERT_EQ(8, pages.size());

+ ASSERT_EQ(8U, pages.size());

EXPECT_EQ(1, pages[0]);

EXPECT_EQ(2, pages[1]);

EXPECT_EQ(3, pages[2]);

@@ -32,6 +32,6 @@

TEST(PageRangeTest, Empty) {

printing::PageRanges ranges;

std::vector<int> pages(printing::PageRange::GetPages(ranges));

- EXPECT_EQ(0, pages.size());

+ EXPECT_EQ(0U, pages.size());

}

« no previous file with comments | « chrome/browser/printing/page_number.h ('k') | chrome/browser/printing/units_unittest.cc » ('j') | chrome/browser/session_startup_pref.cc » ('J')