Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 314893003: Set referrer for CSS resources (Closed)

Created:
6 years, 6 months ago by bashi
Modified:
6 years, 6 months ago
CC:
blink-reviews, blink-reviews-css, blink-reviews-html_chromium.org, ed+blinkwatch_opera.com, dglazkov+blink, darktears, rune+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Set referrer for CSS resources The previous CL (r172433) was reverted because it caused regression. This is second attempt to set referrer for css resource fetching. - Add WebCore::Referrer (not String) object to CSSParserContext - Pass the referrer to CSSImageValue, CSSImageSetValue, and CSSFontFaceSrcValue - Set the referrer when fetching BUG=380457, 377864 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175519

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+317 lines, -23 lines) Patch
A LayoutTests/http/tests/css/css-resources-referrer.html View 1 chunk +48 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/css/css-resources-referrer-expected.html View 1 chunk +34 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/css/css-resources-referrer-srcdoc.html View 1 chunk +36 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/css/css-resources-referrer-srcdoc-expected.html View 1 chunk +23 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/css/resources/css-resources-referrer.css View 1 chunk +16 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/css/resources/css-resources-referrer-import.css View 1 chunk +14 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/css/resources/referrer-check.php View 1 chunk +52 lines, -0 lines 0 comments Download
A + LayoutTests/http/tests/security/mixedContent/insecure-css-resources.html View 2 chunks +6 lines, -9 lines 0 comments Download
A LayoutTests/http/tests/security/mixedContent/insecure-css-resources-expected.txt View 1 chunk +7 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/security/mixedContent/resources/fetch-insecure-css-resources.css View 1 chunk +9 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/security/mixedContent/resources/frame-with-insecure-css-resources.html View 1 chunk +15 lines, -0 lines 0 comments Download
M Source/core/css/CSSCursorImageValue.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/css/CSSFontFaceSrcValue.h View 3 chunks +3 lines, -0 lines 0 comments Download
M Source/core/css/CSSFontFaceSrcValue.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/css/CSSImageSetValue.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/css/CSSImageSetValue.cpp View 3 chunks +4 lines, -2 lines 0 comments Download
M Source/core/css/CSSImageValue.h View 3 chunks +5 lines, -0 lines 0 comments Download
M Source/core/css/CSSImageValue.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/css/CSSParserMode.h View 4 chunks +4 lines, -0 lines 0 comments Download
M Source/core/css/CSSParserMode.cpp View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/css/StyleRuleImport.cpp View 1 chunk +5 lines, -2 lines 0 comments Download
M Source/core/css/parser/CSSPropertyParser.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/css/parser/CSSPropertyParser.cpp View 8 chunks +14 lines, -6 lines 0 comments Download
M Source/core/html/HTMLBodyElement.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/HTMLTableElement.cpp View 2 chunks +6 lines, -2 lines 0 comments Download
M Source/core/html/HTMLTablePartElement.cpp View 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
bashi
Hi jochen@, Could you take a look? I added a test for insecure css resource ...
6 years, 6 months ago (2014-06-04 07:21:09 UTC) #1
jochen (gone - plz use gerrit)
lgtm, thanks!
6 years, 6 months ago (2014-06-04 07:30:25 UTC) #2
bashi
The CQ bit was checked by bashi@chromium.org
6 years, 6 months ago (2014-06-05 01:04:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bashi@chromium.org/314893003/1
6 years, 6 months ago (2014-06-05 01:05:18 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-05 01:11:18 UTC) #5
Message was sent while issue was closed. 
Change committed as 175519

Powered by Google App Engine
This is Rietveld 408576698