Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 314863004: Add athena_unittests to chromiumos (Closed)

Created:
6 years, 6 months ago by Peter Mayo
Modified:
6 years, 6 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Add trybots too #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M testing/buildbot/chromium.chromiumos.json View 2 chunks +3 lines, -1 line 0 comments Download
M testing/buildbot/chromium_trybot.json View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Peter Mayo
This looks like it will do the right thing. (tryjobs still running as I send ...
6 years, 6 months ago (2014-06-06 14:06:42 UTC) #1
Paweł Hajdan Jr.
LGTM
6 years, 6 months ago (2014-06-06 17:20:24 UTC) #2
Peter Mayo
The CQ bit was checked by petermayo@chromium.org
6 years, 6 months ago (2014-06-06 17:23:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/petermayo@chromium.org/314863004/20001
6 years, 6 months ago (2014-06-06 17:24:55 UTC) #4
oshima
lgtm thanks. will this cover memory bots as well?
6 years, 6 months ago (2014-06-06 17:31:57 UTC) #5
Peter Mayo
On 2014/06/06 17:31:57, oshima wrote: > lgtm > > thanks. will this cover memory bots ...
6 years, 6 months ago (2014-06-06 18:06:32 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-06 20:14:36 UTC) #7
Message was sent while issue was closed.
Change committed as 275506

Powered by Google App Engine
This is Rietveld 408576698