Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Issue 314833002: Remove FastPaint. (Closed)

Created:
6 years, 6 months ago by sandersd (OOO until July 31)
Modified:
6 years, 6 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Remove FastPaint. FastPaint (which avoids creating a copy of video frames in the native pixel format) was enabled only for software compositing in the case where the render target was opaque (that is to say, wasn't enabled). This removes calls to our own pixel format conversion code that don't have exact equivalents in libYUV. BUG=369375 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275501

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix includes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -365 lines) Patch
M media/filters/skcanvas_video_renderer.cc View 1 3 chunks +0 lines, -211 lines 0 comments Download
M media/filters/skcanvas_video_renderer_unittest.cc View 4 chunks +48 lines, -154 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
sandersd (OOO until July 31)
6 years, 6 months ago (2014-06-05 18:20:42 UTC) #1
scherkus (not reviewing)
lgtm w/ nit https://codereview.chromium.org/314833002/diff/1/media/filters/skcanvas_video_renderer.cc File media/filters/skcanvas_video_renderer.cc (right): https://codereview.chromium.org/314833002/diff/1/media/filters/skcanvas_video_renderer.cc#newcode12 media/filters/skcanvas_video_renderer.cc:12: #include "third_party/skia/include/core/SkDevice.h" nit: I think we ...
6 years, 6 months ago (2014-06-05 18:25:59 UTC) #2
scherkus (not reviewing)
also you need to beef up your CL description for example ... explaining why it's ...
6 years, 6 months ago (2014-06-05 18:27:43 UTC) #3
sandersd (OOO until July 31)
The CQ bit was checked by sandersd@chromium.org
6 years, 6 months ago (2014-06-05 21:51:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sandersd@chromium.org/314833002/20001
6 years, 6 months ago (2014-06-05 21:53:36 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-06 02:39:38 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-06 03:36:41 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/builds/39120)
6 years, 6 months ago (2014-06-06 03:36:42 UTC) #8
sandersd (OOO until July 31)
The CQ bit was checked by sandersd@chromium.org
6 years, 6 months ago (2014-06-06 18:10:22 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sandersd@chromium.org/314833002/20001
6 years, 6 months ago (2014-06-06 18:11:52 UTC) #10
commit-bot: I haz the power
6 years, 6 months ago (2014-06-06 19:25:28 UTC) #11
Message was sent while issue was closed.
Change committed as 275501

Powered by Google App Engine
This is Rietveld 408576698