Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 31483002: Move CrossThreadCopier.cpp/.h to platform/ (Closed)

Created:
7 years, 2 months ago by pilgrim_google
Modified:
7 years, 2 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org, darin (slow to review)
Visibility:
Public.

Description

Move CrossThreadCopier.cpp/.h to platform/ BUG=297477 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160144

Patch Set 1 #

Total comments: 1

Patch Set 2 : add macros #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -324 lines) Patch
M Source/core/core.gypi View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/dom/CrossThreadTask.h View 1 chunk +1 line, -1 line 0 comments Download
D Source/core/platform/CrossThreadCopier.h View 1 chunk +0 lines, -179 lines 0 comments Download
D Source/core/platform/CrossThreadCopier.cpp View 1 chunk +0 lines, -133 lines 0 comments Download
M Source/modules/websockets/ThreadableWebSocketChannelClientWrapper.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + Source/platform/CrossThreadCopier.h View 1 2 chunks +6 lines, -5 lines 0 comments Download
A + Source/platform/CrossThreadCopier.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/blink_platform.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/web/DatabaseObserver.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WorkerAllowMainThreadBridgeBase.h View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
pilgrim_google
Not sure if any PLATFORM_EXPORTs are required here.
7 years, 2 months ago (2013-10-21 02:49:34 UTC) #1
abarth-chromium
LGTM assuming you add enough PLATFORM_EXPORTs to get it building. https://codereview.chromium.org/31483002/diff/1/Source/platform/CrossThreadCopier.cpp File Source/platform/CrossThreadCopier.cpp (right): https://codereview.chromium.org/31483002/diff/1/Source/platform/CrossThreadCopier.cpp#newcode67 ...
7 years, 2 months ago (2013-10-21 03:11:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pilgrim@chromium.org/31483002/70001
7 years, 2 months ago (2013-10-21 13:48:22 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=12697
7 years, 2 months ago (2013-10-21 16:32:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pilgrim@chromium.org/31483002/180001
7 years, 2 months ago (2013-10-21 18:19:21 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=12794
7 years, 2 months ago (2013-10-21 21:06:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pilgrim@chromium.org/31483002/180001
7 years, 2 months ago (2013-10-22 01:48:30 UTC) #7
commit-bot: I haz the power
7 years, 2 months ago (2013-10-22 06:54:26 UTC) #8
Message was sent while issue was closed. 
Change committed as 160144

Powered by Google App Engine
This is Rietveld 408576698