Allow unit tests to use a mock audio input controller.

Allow unit tests to use a mock audio input controller.
This is modelled after chrome/common/net/test_url_fetcher_factory.h. Using this mock unit tests can stub out the audio recording part and test the consumer of the audio data.
I have also added a new media_test_support target to media.gyp, this will be used in subsequent CLs for testing speech input code.
BUG=none
TEST=none, this code will get used in future unit tests

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=55627

[jorlow, 2010-08-10 17:35:57]

Few nits I noticed, but I really don't think I'm the right reviewer for this.

http://codereview.chromium.org/3148003/diff/1/5
File media/audio/test_audio_input_controller_factory.h (right):

http://codereview.chromium.org/3148003/diff/1/5#newcode54
media/audio/test_audio_input_controller_factory.h:54: // These are not owned by
us and expected to be valid for this object's lifetime.
> 80 cols

http://codereview.chromium.org/3148003/diff/1/5#newcode61
media/audio/test_audio_input_controller_factory.h:61: // Simple
AudioInputController::Factory method that creates TestAudioInputControllers.
> 80 cols

http://codereview.chromium.org/3148003/diff/1/5#newcode67
media/audio/test_audio_input_controller_factory.h:67: AudioInputController*
Create(AudioInputController::EventHandler* event_handler,
> 80 cols

[Satish, 2010-08-10 20:31:55]

Thanks, I've included Alpha and Carlos who are more familiar with the audio code
to review as well.

[Alpha Left Google, 2010-08-10 20:40:43]

Mostly nits and one question.

I recommend you use gmock for creating a mock object, but it's okay that you
write your own.

[Alpha Left Google, 2010-08-10 20:44:25]

http://codereview.chromium.org/3148003/diff/1/5
File media/audio/test_audio_input_controller_factory.h (right):

http://codereview.chromium.org/3148003/diff/1/5#newcode18
media/audio/test_audio_input_controller_factory.h:18: //
TestAudioInputController::Record and Close are overriden to do nothing. It is
nit: Empty line above this.

http://codereview.chromium.org/3148003/diff/1/5#newcode22
media/audio/test_audio_input_controller_factory.h:22: // Typical usage:
nit: empty line above this.

http://codereview.chromium.org/3148003/diff/1/5#newcode26
media/audio/test_audio_input_controller_factory.h:26: //   // Do something that
triggers creation of an AudioInputController.
nit: empty line above this.

http://codereview.chromium.org/3148003/diff/1/5#newcode29
media/audio/test_audio_input_controller_factory.h:29: //   // Notify event
handler with whatever data you want.
nit: empty line above this.

http://codereview.chromium.org/3148003/diff/1/5#newcode31
media/audio/test_audio_input_controller_factory.h:31: //   // Do something that
triggers AudioInputController::Record to be called.
nit: empty line above this.

http://codereview.chromium.org/3148003/diff/1/5#newcode34
media/audio/test_audio_input_controller_factory.h:34: //   // Make sure consumer
of AudioInputController does the right thing.
nit: empty line above this.

http://codereview.chromium.org/3148003/diff/1/6
File media/media.gyp (right):

http://codereview.chromium.org/3148003/diff/1/6#newcode288
media/media.gyp:288: {
Is the test going to be in media_unittests or are you intended to use these test
objects else where?

[Satish, 2010-08-10 20:57:35]

Thanks, fixed style issues and one reply below:

> http://codereview.chromium.org/3148003/diff/1/6#newcode288
> media/media.gyp:288: {
> Is the test going to be in media_unittests or are you intended to use these
test
> objects else where?

Elsewhere.. the first test to use media_test_support will be in
chrome/browser/speech.

[Alpha Left Google, 2010-08-10 21:03:33]

On 2010/08/10 20:57:35, Satish wrote:
> Thanks, fixed style issues and one reply below:
> 
> > http://codereview.chromium.org/3148003/diff/1/6#newcode288
> > media/media.gyp:288: {
> > Is the test going to be in media_unittests or are you intended to use these
> test
> > objects else where?
> 
> Elsewhere.. the first test to use media_test_support will be in
> chrome/browser/speech.

LGTM.