Separate the generated files from core and modules to their own sub-dirs.

Separate the generated files from core and modules to their own sub-dirs.

BUG=380054
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175513

[eseidel, 2014-06-03 22:17:20]

lgtm

lgtm if it builds.

[c.shu, 2014-06-04 00:01:31]

On 2014/06/03 22:17:20, eseidel wrote:
> lgtm
> 
> lgtm if it builds.

Thanks, Eric. It seems all bots built but there are some failed tests on
linux_blink_rel. I don't think they are related to this CL though.

[haraken, 2014-06-04 01:06:40]

LGTM.

This will affect nbarth's CL (https://codereview.chromium.org/310563004/), so
nbarth should confirm.

[Nils Barth (inactive), 2014-06-04 03:01:13]

On 2014/06/04 01:06:40, haraken wrote:
> LGTM.
> 
> This will affect nbarth's CL (https://codereview.chromium.org/310563004/), so
> nbarth should confirm.

Hi Chang,
thanks for this; could you wait until my other CL lands and rebase first?
Thanks!

[Nils Barth (inactive), 2014-06-04 06:09:28]

A few nits, otherwise fine once my bindings CL lands and this is rebased.

https://codereview.chromium.org/314783004/diff/20001/Source/core/core.gyp
File Source/core/core.gyp (right):

https://codereview.chromium.org/314783004/diff/20001/Source/core/core.gyp#new...
Source/core/core.gyp:46: '<(core_output_dir)',
Could you put this dir *below* the "qualified includes" FIXME?
(core/ should be qualified as well)

https://codereview.chromium.org/314783004/diff/20001/Source/core/core.gyp#new...
Source/core/core.gyp:47: # FIXME: Remove this after cleaning up platform
dependecies on core and modules.
Thanks for the great explanation!

https://codereview.chromium.org/314783004/diff/20001/Source/modules/modules.gyp
File Source/modules/modules.gyp (right):

https://codereview.chromium.org/314783004/diff/20001/Source/modules/modules.g...
Source/modules/modules.gyp:51: 'include_dirs': [
Could you add a FIXME to remove once qualified, as per the one in core.gyp?

[Nils Barth (inactive), 2014-06-04 09:37:12]

To not block: LGTM (once my CL lands shortly, and rebased/nits fixed).

https://codereview.chromium.org/314783004/diff/20001/Source/bindings/bindings...
File Source/bindings/bindings.gypi (right):

https://codereview.chromium.org/314783004/diff/20001/Source/bindings/bindings...
Source/bindings/bindings.gypi:11: 'core_output_dir':
'<(SHARED_INTERMEDIATE_DIR)/blink/core',
This will actually be defined in:
Source/core/core_generated.gypi
...once my CL lands.
...and likewise for modules.

[c.shu, 2014-06-04 16:00:41]

https://codereview.chromium.org/314783004/diff/20001/Source/bindings/bindings...
File Source/bindings/bindings.gypi (right):

https://codereview.chromium.org/314783004/diff/20001/Source/bindings/bindings...
Source/bindings/bindings.gypi:11: 'core_output_dir':
'<(SHARED_INTERMEDIATE_DIR)/blink/core',
On 2014/06/04 09:37:12, Nils Barth wrote:
> This will actually be defined in:
> Source/core/core_generated.gypi
> ...once my CL lands.
> ...and likewise for modules.

Done.

https://codereview.chromium.org/314783004/diff/20001/Source/core/core.gyp
File Source/core/core.gyp (right):

https://codereview.chromium.org/314783004/diff/20001/Source/core/core.gyp#new...
Source/core/core.gyp:46: '<(core_output_dir)',
On 2014/06/04 06:09:28, Nils Barth wrote:
> Could you put this dir *below* the "qualified includes" FIXME?
> (core/ should be qualified as well)

Done.

https://codereview.chromium.org/314783004/diff/20001/Source/modules/modules.gyp
File Source/modules/modules.gyp (right):

https://codereview.chromium.org/314783004/diff/20001/Source/modules/modules.g...
Source/modules/modules.gyp:51: 'include_dirs': [
On 2014/06/04 06:09:28, Nils Barth wrote:
> Could you add a FIXME to remove once qualified, as per the one in core.gyp?

Done.

[c.shu, 2014-06-04 17:39:56]

The CQ bit was checked by c.shu@samsung.com

[commit-bot: I haz the power, 2014-06-04 17:40:19]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/c.shu@samsung.com/314783004/80001

[commit-bot: I haz the power, 2014-06-04 18:51:19]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_blink_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/1...)

[commit-bot: I haz the power, 2014-06-04 20:34:08]

Change committed as 175513

[Nils Barth (inactive), 2014-06-06 03:14:20]

On 2014/06/04 20:34:08, I haz the power (commit-bot) wrote:
> Change committed as 175513

This CL caused build failures on later CLs, because it requires a clobber build,
otherwise old (stale) generated files are used.

In future this can be avoided by notifying the Blink gardener and asking them
to include a landmine in the Blink roll that contains this kind of CL.

Details documented at:
http://www.chromium.org/Home/chromium-clobber-landmines

See discussion at:
https://code.google.com/p/chromium/issues/detail?id=381111#c4

This is a subtle issue, so it's easy to miss (as we did this time -- sorry!),
but we should be on alert for it while moving files around.

Hopefully we're mostly finished moving files, but this may happen in future.

[Nils Barth (inactive), 2014-06-06 05:44:00]

oh, and fix posted at:
Add landmine due to generated file move in Blink r175513
https://codereview.chromium.org/316343003/