Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1691)

Unified Diff: runtime/vm/intrinsifier_arm.cc

Issue 314783003: Eliminates some branches from arm code. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/intermediate_language_arm.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/intrinsifier_arm.cc
===================================================================
--- runtime/vm/intrinsifier_arm.cc (revision 36949)
+++ runtime/vm/intrinsifier_arm.cc (working copy)
@@ -949,9 +949,8 @@
__ b(&fall_through, NE);
// Receiver is Mint, return false if right is Smi.
__ tst(R0, Operand(kSmiTagMask));
- __ b(&fall_through, NE);
- __ LoadObject(R0, Bool::False());
- __ Ret();
+ __ LoadObject(R0, Bool::False(), EQ);
+ __ bx(LR, EQ);
// TODO(srdjan): Implement Mint == Mint comparison.
__ Bind(&fall_through);
@@ -1228,9 +1227,8 @@
// Overflow is signaled with minint.
// Check for overflow and that it fits into Smi.
__ CompareImmediate(R0, 0xC0000000);
- __ b(&fall_through, MI);
- __ SmiTag(R0);
- __ Ret();
+ __ SmiTag(R0, PL);
+ __ bx(LR, PL);
__ Bind(&fall_through);
}
}
« no previous file with comments | « runtime/vm/intermediate_language_arm.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698