Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7446)

Unified Diff: chrome/browser/search_engines/template_url.cc

Issue 314773002: Omnibox: Send Input Type to Suggest Server (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix (legitimate) clang error Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/search_engines/template_url.cc
diff --git a/chrome/browser/search_engines/template_url.cc b/chrome/browser/search_engines/template_url.cc
index e3eac0bc5da032b6ca5b2a4062204a4e0fef5bc5..8dd8e656a42ebc3c862f2f69305c6485cee9b275 100644
--- a/chrome/browser/search_engines/template_url.cc
+++ b/chrome/browser/search_engines/template_url.cc
@@ -28,6 +28,7 @@
#include "chrome/browser/search_engines/template_url_service.h"
#include "chrome/common/chrome_switches.h"
#include "chrome/common/chrome_version_info.h"
+#include "components/metrics/proto/omnibox_input_type.pb.h"
#include "extensions/common/constants.h"
#include "google_apis/google_api_keys.h"
#include "net/base/escape.h"
@@ -67,6 +68,7 @@ const char kGoogleBookmarkBarPinnedParameter[] = "google:bookmarkBarPinned";
const char kGoogleCurrentPageUrlParameter[] = "google:currentPageUrl";
const char kGoogleCursorPositionParameter[] = "google:cursorPosition";
const char kGoogleForceInstantResultsParameter[] = "google:forceInstantResults";
+const char kGoogleInputTypeParameter[] = "google:inputType";
const char kGoogleInstantExtendedEnabledParameter[] =
"google:instantExtendedEnabledParameter";
const char kGoogleInstantExtendedEnabledKey[] =
@@ -201,6 +203,7 @@ bool ShowingSearchTermsOnSRP() {
TemplateURLRef::SearchTermsArgs::SearchTermsArgs(
const base::string16& search_terms)
: search_terms(search_terms),
+ input_type(metrics::OmniboxInputType::INVALID),
accepted_suggestion(NO_SUGGESTIONS_AVAILABLE),
cursor_position(base::string16::npos),
omnibox_start_margin(-1),
@@ -566,6 +569,8 @@ bool TemplateURLRef::ParseParameter(size_t start,
replacements->push_back(Replacement(GOOGLE_CURRENT_PAGE_URL, start));
} else if (parameter == kGoogleCursorPositionParameter) {
replacements->push_back(Replacement(GOOGLE_CURSOR_POSITION, start));
+ } else if (parameter == kGoogleForceInstantResultsParameter) {
+ replacements->push_back(Replacement(GOOGLE_FORCE_INSTANT_RESULTS, start));
} else if (parameter == kGoogleImageOriginalHeight) {
replacements->push_back(
Replacement(TemplateURLRef::GOOGLE_IMAGE_ORIGINAL_HEIGHT, start));
@@ -580,8 +585,9 @@ bool TemplateURLRef::ParseParameter(size_t start,
} else if (parameter == kGoogleImageURLParameter) {
replacements->push_back(Replacement(TemplateURLRef::GOOGLE_IMAGE_URL,
start));
- } else if (parameter == kGoogleForceInstantResultsParameter) {
- replacements->push_back(Replacement(GOOGLE_FORCE_INSTANT_RESULTS, start));
+ } else if (parameter == kGoogleInputTypeParameter) {
+ replacements->push_back(Replacement(TemplateURLRef::GOOGLE_INPUT_TYPE,
+ start));
} else if (parameter == kGoogleInstantExtendedEnabledParameter) {
replacements->push_back(Replacement(GOOGLE_INSTANT_EXTENDED_ENABLED,
start));
@@ -902,6 +908,12 @@ std::string TemplateURLRef::HandleReplacements(
&url);
break;
+ case GOOGLE_INPUT_TYPE:
+ DCHECK(!i->is_post_param);
+ HandleReplacement(
+ "oit", base::IntToString(search_terms_args.input_type), *i, &url);
+ break;
+
case GOOGLE_INSTANT_EXTENDED_ENABLED:
DCHECK(!i->is_post_param);
HandleReplacement(std::string(),
« no previous file with comments | « chrome/browser/search_engines/template_url.h ('k') | chrome/browser/search_engines/template_url_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698