Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Unified Diff: tools/bisect-perf-regression.py

Issue 314763002: Parse revisions for dependency repositories from DEPS file. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/bisect-perf-regression.py
diff --git a/tools/bisect-perf-regression.py b/tools/bisect-perf-regression.py
index 721ca55696eba444030107327bdf843126aaafa0..2db8c8d66e068575c059bf467fca071855385a86 100755
--- a/tools/bisect-perf-regression.py
+++ b/tools/bisect-perf-regression.py
@@ -1438,16 +1438,17 @@ class BisectPerformanceMetrics(object):
continue
if (depot_data.get('recurse') and depot in depot_data.get('from')):
- src_dir = (deps_data.get(depot_data.get('src')) or
- deps_data.get(depot_data.get('src_old')))
+ depot_data_src = depot_data.get('src') or depot_data.get('src_old')
+ src_dir = deps_data.get(depot_data_src)
if src_dir:
- self.depot_cwd[depot_name] = os.path.join(self.src_cwd, src_dir[4:])
- re_results = rxp.search(deps_data.get(src_dir, ''))
+ self.depot_cwd[depot_name] = os.path.join(self.src_cwd,
+ depot_data_src[4:])
+ re_results = rxp.search(src_dir)
if re_results:
results[depot_name] = re_results.group('revision')
else:
warning_text = ('Couldn\'t parse revision for %s while bisecting '
- '%s' % (depot_name, depot))
+ '%s' % (depot_name, depot))
if not warning_text in self.warnings:
self.warnings.append(warning_text)
else:
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698