Set up Finch experiment for expanded GPU rasterization trigger

Set up field trial for expanded GPU rasterization trigger

This expands the GPU rasterization trigger for a field trial.

This depends on Blink CL http://crrev.com/309593007

BUG=380454
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275769

[ajuma, 2014-06-04 15:03:29]

vangelis: overall review
asvitkine: chrome_browser_field_trials.cc
jochen: content/

[Alexei Svitkine (slow), 2014-06-04 18:05:08]

https://codereview.chromium.org/314753002/diff/20001/chrome/browser/chrome_br...
File chrome/browser/chrome_browser_field_trials.cc (right):

https://codereview.chromium.org/314753002/diff/20001/chrome/browser/chrome_br...
chrome/browser/chrome_browser_field_trials.cc:64:
base::FieldTrialList::FindValue("GpuRasterizationExpandedContentWhitelist");
This is actually unnecessary now. You can just mark your server-side config with
starts_active: true to achieve the same effect without needing this line.

https://codereview.chromium.org/314753002/diff/20001/content/renderer/render_...
File content/renderer/render_view_impl.cc (right):

https://codereview.chromium.org/314753002/diff/20001/content/renderer/render_...
content/renderer/render_view_impl.cc:483:
kGpuRasterizationContentWhitelistFieldTrialName) ==
Nit: I think it's cleaner without the extra constants - just inline the literals
into the call and cond.

[ajuma, 2014-06-04 18:25:33]

https://codereview.chromium.org/314753002/diff/20001/chrome/browser/chrome_br...
File chrome/browser/chrome_browser_field_trials.cc (right):

https://codereview.chromium.org/314753002/diff/20001/chrome/browser/chrome_br...
chrome/browser/chrome_browser_field_trials.cc:64:
base::FieldTrialList::FindValue("GpuRasterizationExpandedContentWhitelist");
On 2014/06/04 18:05:09, Alexei Svitkine wrote:
> This is actually unnecessary now. You can just mark your server-side config
with
> starts_active: true to achieve the same effect without needing this line.

Done.

https://codereview.chromium.org/314753002/diff/20001/content/renderer/render_...
File content/renderer/render_view_impl.cc (right):

https://codereview.chromium.org/314753002/diff/20001/content/renderer/render_...
content/renderer/render_view_impl.cc:483:
kGpuRasterizationContentWhitelistFieldTrialName) ==
On 2014/06/04 18:05:09, Alexei Svitkine wrote:
> Nit: I think it's cleaner without the extra constants - just inline the
literals
> into the call and cond.

Done.

[Alexei Svitkine (slow), 2014-06-04 18:27:34]

lgtm

[jochen (gone - plz use gerrit), 2014-06-05 07:17:06]

lgtm

[ajuma, 2014-06-08 19:14:36]

The CQ bit was checked by ajuma@chromium.org

[commit-bot: I haz the power, 2014-06-08 19:15:02]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ajuma@chromium.org/314753002/40001

[commit-bot: I haz the power, 2014-06-09 05:02:13]

Change committed as 275769