Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 314733003: Include the display description in the picker on ChromeOS (Closed)

Created:
6 years, 6 months ago by robert.bradford
Modified:
6 years, 6 months ago
Reviewers:
oshima
CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Include the display description in the picker on ChromeOS The DesktopMediaListAsh uses the AuraWindow's title as the description for the desktop source (window or screen.) To ensure that the display's description appears we need to set the root window's title to the display's name. This display name matches the name shown in the display configuration UI. BUG=372444 TEST=In a multiple display environment trigger the picker and observe that the displays' names are included and match those in the display settings UI. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274599

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M ash/display/display_controller.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
robert.bradford
6 years, 6 months ago (2014-06-03 16:37:22 UTC) #1
oshima
lgtm
6 years, 6 months ago (2014-06-03 16:38:38 UTC) #2
robert.bradford
The CQ bit was checked by robert.bradford@intel.com
6 years, 6 months ago (2014-06-03 16:52:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/robert.bradford@intel.com/314733003/1
6 years, 6 months ago (2014-06-03 16:53:57 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-03 19:59:36 UTC) #5
Message was sent while issue was closed.
Change committed as 274599

Powered by Google App Engine
This is Rietveld 408576698