media/audio/alsa/alsa_input.h - Issue 314713002: Modifies AudioInputCallback::OnData and use media::AudioBus instead of plain byte vector

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/audio/alsa/alsa_input.h

Issue 314713002: Modifies AudioInputCallback::OnData and use media::AudioBus instead of plain byte vector (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Now uses AudioBus::WrapMemory instead of From/ToInterleaved Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/renderer_host/media/audio_input_sync_writer.cc ('K') | « media/audio/agc_audio_stream.h ('k') | media/audio/alsa/alsa_input.cc » ('j') | media/audio/audio_input_controller.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: media/audio/alsa/alsa_input.h

diff --git a/media/audio/alsa/alsa_input.h b/media/audio/alsa/alsa_input.h

index 90c388382a0b68f5c0be8238cca5bbdd3ab46d9f..c26f3e2b66eb2287b687283721823ed64d882dcd 100644

--- a/media/audio/alsa/alsa_input.h

+++ b/media/audio/alsa/alsa_input.h

@@ -82,6 +82,7 @@ class AlsaPcmInputStream : public AgcAudioStream<AudioInputStream> {

snd_mixer_elem_t* mixer_element_handle_; // Handle to the capture element.

scoped_ptr<uint8[]> audio_buffer_; // Buffer used for reading audio data.

bool read_callback_behind_schedule_;

+ scoped_ptr<AudioBus> audio_bus_;

// NOTE: Weak pointers must be invalidated before all other member variables.

base::WeakPtrFactory<AlsaPcmInputStream> weak_factory_;