Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Unified Diff: media/audio/audio_low_latency_input_output_unittest.cc

Issue 314713002: Modifies AudioInputCallback::OnData and use media::AudioBus instead of plain byte vector (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fixed SpeechRecognitionBrowserTest Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/audio/audio_low_latency_input_output_unittest.cc
diff --git a/media/audio/audio_low_latency_input_output_unittest.cc b/media/audio/audio_low_latency_input_output_unittest.cc
index 2ae700a874bd8d87b560418168c0570551c4b060..289505b4ac8fac188108961082194f513a6f769e 100644
--- a/media/audio/audio_low_latency_input_output_unittest.cc
+++ b/media/audio/audio_low_latency_input_output_unittest.cc
@@ -184,7 +184,7 @@ class FullDuplexAudioSinkSource
// AudioInputStream::AudioInputCallback.
virtual void OnData(AudioInputStream* stream,
- const uint8* src, uint32 size,
+ const AudioBus* source,
uint32 hardware_delay_bytes,
double volume) OVERRIDE {
base::AutoLock lock(lock_);
@@ -203,6 +203,11 @@ class FullDuplexAudioSinkSource
++input_elements_to_write_;
}
+// TODO(henrika): This test is currently disabled but it would be nice to
+// add support for it just in case someone needs it again. If so, this
+// scope should be re-enabled and work on audio buses instead of plain
+// bytes.
+#if (false)
DaleCurtis 2014/06/17 01:03:50 What is this actually testing? It seems to just ad
henrika (OOO until Aug 14) 2014/06/17 11:39:44 The buffer is read out in the OnMoreData, hence yo
// Store the captured audio packet in a seekable media buffer.
if (!buffer_->Append(src, size)) {
// An attempt to write outside the buffer limits has been made.
@@ -211,6 +216,7 @@ class FullDuplexAudioSinkSource
buffer_->set_forward_capacity(2 * buffer_->forward_capacity());
buffer_->Clear();
}
+#endif
}
virtual void OnError(AudioInputStream* stream) OVERRIDE {}

Powered by Google App Engine
This is Rietveld 408576698