Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(559)

Side by Side Diff: content/browser/renderer_host/media/audio_input_sync_writer.cc

Issue 314713002: Modifies AudioInputCallback::OnData and use media::AudioBus instead of plain byte vector (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: nits Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/renderer_host/media/audio_input_sync_writer.h" 5 #include "content/browser/renderer_host/media/audio_input_sync_writer.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <algorithm>
8 9
9 #include "base/memory/shared_memory.h" 10 #include "base/memory/shared_memory.h"
10 #include "content/browser/renderer_host/media/media_stream_manager.h" 11 #include "content/browser/renderer_host/media/media_stream_manager.h"
11 12
13 using media::AudioBus;
14
12 namespace content { 15 namespace content {
13 16
14 AudioInputSyncWriter::AudioInputSyncWriter( 17 AudioInputSyncWriter::AudioInputSyncWriter(base::SharedMemory* shared_memory,
15 base::SharedMemory* shared_memory, 18 int shared_memory_segment_count,
16 int shared_memory_segment_count) 19 const media::AudioParameters& params)
17 : shared_memory_(shared_memory), 20 : shared_memory_(shared_memory),
18 shared_memory_segment_count_(shared_memory_segment_count), 21 shared_memory_segment_count_(shared_memory_segment_count),
19 current_segment_id_(0), 22 current_segment_id_(0),
20 creation_time_(base::Time::Now()) { 23 creation_time_(base::Time::Now()),
24 audio_bus_memory_size_(AudioBus::CalculateMemorySize(params)) {
21 DCHECK_GT(shared_memory_segment_count, 0); 25 DCHECK_GT(shared_memory_segment_count, 0);
22 DCHECK_EQ(shared_memory->requested_size() % shared_memory_segment_count, 0u); 26 DCHECK_EQ(shared_memory->requested_size() % shared_memory_segment_count, 0u);
23 shared_memory_segment_size_ = 27 shared_memory_segment_size_ =
24 shared_memory->requested_size() / shared_memory_segment_count; 28 shared_memory->requested_size() / shared_memory_segment_count;
29 DVLOG(1) << "SharedMemory::requested_size: "
30 << shared_memory->requested_size();
31 DVLOG(1) << "shared_memory_segment_count: " << shared_memory_segment_count;
32
33 // Create vector of audio buses by wrapping existing blocks of memory.
34 uint8* ptr = static_cast<uint8*>(shared_memory_->memory());
35 for (int i = 0; i < shared_memory_segment_count; ++i) {
36 media::AudioInputBuffer* buffer =
37 reinterpret_cast<media::AudioInputBuffer*>(ptr);
38 scoped_ptr<media::AudioBus> audio_bus =
39 media::AudioBus::WrapMemory(params, buffer->audio);
40 audio_buses_.push_back(audio_bus.release());
41 ptr += shared_memory_segment_size_;
42 }
25 } 43 }
26 44
27 AudioInputSyncWriter::~AudioInputSyncWriter() {} 45 AudioInputSyncWriter::~AudioInputSyncWriter() {}
28 46
29 // TODO(henrika): Combine into one method (including Write). 47 // TODO(henrika): Combine into one method (including Write).
30 void AudioInputSyncWriter::UpdateRecordedBytes(uint32 bytes) { 48 void AudioInputSyncWriter::UpdateRecordedBytes(uint32 bytes) {
31 socket_->Send(&bytes, sizeof(bytes)); 49 socket_->Send(&bytes, sizeof(bytes));
32 } 50 }
33 51
34 uint32 AudioInputSyncWriter::Write(const void* data, 52 void AudioInputSyncWriter::Write(const media::AudioBus* data,
35 uint32 size, 53 double volume,
36 double volume, 54 bool key_pressed) {
37 bool key_pressed) {
38 #if !defined(OS_ANDROID) 55 #if !defined(OS_ANDROID)
39 static const base::TimeDelta kLogDelayThreadhold = 56 static const base::TimeDelta kLogDelayThreadhold =
40 base::TimeDelta::FromMilliseconds(500); 57 base::TimeDelta::FromMilliseconds(500);
41 58
42 std::ostringstream oss; 59 std::ostringstream oss;
43 if (last_write_time_.is_null()) { 60 if (last_write_time_.is_null()) {
44 // This is the first time Write is called. 61 // This is the first time Write is called.
45 base::TimeDelta interval = base::Time::Now() - creation_time_; 62 base::TimeDelta interval = base::Time::Now() - creation_time_;
46 oss << "Audio input data received for the first time: delay = " 63 oss << "Audio input data received for the first time: delay = "
47 << interval.InMilliseconds() << "ms."; 64 << interval.InMilliseconds() << "ms.";
48 65
49 } else { 66 } else {
50 base::TimeDelta interval = base::Time::Now() - last_write_time_; 67 base::TimeDelta interval = base::Time::Now() - last_write_time_;
51 if (interval > kLogDelayThreadhold) { 68 if (interval > kLogDelayThreadhold) {
52 oss << "Audio input data delay unexpectedly long: delay = " 69 oss << "Audio input data delay unexpectedly long: delay = "
53 << interval.InMilliseconds() << "ms."; 70 << interval.InMilliseconds() << "ms.";
54 } 71 }
55 } 72 }
56 if (!oss.str().empty()) 73 if (!oss.str().empty())
57 MediaStreamManager::SendMessageToNativeLog(oss.str()); 74 MediaStreamManager::SendMessageToNativeLog(oss.str());
58 75
59 last_write_time_ = base::Time::Now(); 76 last_write_time_ = base::Time::Now();
60 #endif 77 #endif
61 78
79 // Write audio parameters to shared memory.
62 uint8* ptr = static_cast<uint8*>(shared_memory_->memory()); 80 uint8* ptr = static_cast<uint8*>(shared_memory_->memory());
63 ptr += current_segment_id_ * shared_memory_segment_size_; 81 ptr += current_segment_id_ * shared_memory_segment_size_;
64 media::AudioInputBuffer* buffer = 82 media::AudioInputBuffer* buffer =
65 reinterpret_cast<media::AudioInputBuffer*>(ptr); 83 reinterpret_cast<media::AudioInputBuffer*>(ptr);
66 buffer->params.volume = volume; 84 buffer->params.volume = volume;
67 buffer->params.size = size; 85 buffer->params.size = audio_bus_memory_size_;
68 buffer->params.key_pressed = key_pressed; 86 buffer->params.key_pressed = key_pressed;
69 memcpy(buffer->audio, data, size); 87
88 // Copy data from the native audio layer into shared memory using pre-
89 // allocated audio buses.
90 media::AudioBus* audio_bus = audio_buses_[current_segment_id_];
91 data->CopyTo(audio_bus);
70 92
71 if (++current_segment_id_ >= shared_memory_segment_count_) 93 if (++current_segment_id_ >= shared_memory_segment_count_)
72 current_segment_id_ = 0; 94 current_segment_id_ = 0;
73
74 return size;
75 } 95 }
76 96
77 void AudioInputSyncWriter::Close() { 97 void AudioInputSyncWriter::Close() {
78 socket_->Close(); 98 socket_->Close();
79 } 99 }
80 100
81 bool AudioInputSyncWriter::Init() { 101 bool AudioInputSyncWriter::Init() {
82 socket_.reset(new base::CancelableSyncSocket()); 102 socket_.reset(new base::CancelableSyncSocket());
83 foreign_socket_.reset(new base::CancelableSyncSocket()); 103 foreign_socket_.reset(new base::CancelableSyncSocket());
84 return base::CancelableSyncSocket::CreatePair(socket_.get(), 104 return base::CancelableSyncSocket::CreatePair(socket_.get(),
(...skipping 17 matching lines...) Expand all
102 base::ProcessHandle process_handle, 122 base::ProcessHandle process_handle,
103 base::FileDescriptor* foreign_handle) { 123 base::FileDescriptor* foreign_handle) {
104 foreign_handle->fd = foreign_socket_->handle(); 124 foreign_handle->fd = foreign_socket_->handle();
105 foreign_handle->auto_close = false; 125 foreign_handle->auto_close = false;
106 return (foreign_handle->fd != -1); 126 return (foreign_handle->fd != -1);
107 } 127 }
108 128
109 #endif 129 #endif
110 130
111 } // namespace content 131 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698