Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 314643004: SK_CPU_ARM --> SK_CPU_ARM32 (Closed)

Created:
6 years, 6 months ago by mtklein_C
Modified:
6 years, 6 months ago
Reviewers:
djsollen, mtklein, reed1
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

SK_CPU_ARM --> SK_CPU_ARM32 That's what it means. It keeps confusing us as named today. BUG=skia: Committed: https://skia.googlesource.com/skia/+/3a2682a77f996f649de7699c9f7bee046c6d4f17

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -14 lines) Patch
M include/core/SkFixed.h View 1 chunk +1 line, -1 line 0 comments Download
M include/core/SkMath.h View 3 chunks +3 lines, -3 lines 0 comments Download
M include/core/SkPostConfig.h View 1 chunk +1 line, -1 line 0 comments Download
M include/core/SkPreConfig.h View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkUtilsArm.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/opts/SkBlitRow_opts_arm_neon.cpp View 1 6 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
mtklein
6 years, 6 months ago (2014-06-03 16:05:30 UTC) #1
mtklein
+Kevin, FYI
6 years, 6 months ago (2014-06-03 17:11:42 UTC) #2
kevin.petit
On 2014/06/03 17:11:42, mtklein wrote: > +Kevin, FYI Thanks for copying me. Looks good to ...
6 years, 6 months ago (2014-06-03 17:32:17 UTC) #3
djsollen
lgtm
6 years, 6 months ago (2014-06-03 17:56:31 UTC) #4
mtklein
+reed for include/. No API changes.
6 years, 6 months ago (2014-06-03 18:33:05 UTC) #5
reed1
lgtm
6 years, 6 months ago (2014-06-03 18:38:38 UTC) #6
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 6 months ago (2014-06-03 18:55:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/314643004/20001
6 years, 6 months ago (2014-06-03 18:55:48 UTC) #8
commit-bot: I haz the power
6 years, 6 months ago (2014-06-03 19:07:35 UTC) #9
Message was sent while issue was closed.
Change committed as 3a2682a77f996f649de7699c9f7bee046c6d4f17

Powered by Google App Engine
This is Rietveld 408576698