Introduce DEFINE_AX_OBJECT_TYPE_CASTS to replace manual toFoo() in accessibility child class

Source/core/accessibility/AXListBoxOption.h

 /*
  * Copyright (C) 2008 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
@@ skipping 57 matching lines @@
 
     virtual bool isListBoxOption() const OVERRIDE { return true; }
     virtual bool canHaveChildren() const OVERRIDE { return false; }
     virtual bool computeAccessibilityIsIgnored() const OVERRIDE;
 
     HTMLSelectElement* listBoxOptionParentNode() const;
     int listBoxOptionIndex() const;
     AXObject* listBoxOptionAXObject(HTMLElement*) const;
 };
 
-inline AXListBoxOption* toAXListBoxOption(AXObject* object)
-{
-    ASSERT_WITH_SECURITY_IMPLICATION(!object || object->isListBoxOption());
-    return static_cast<AXListBoxOption*>(object);
-}
-
-inline const AXListBoxOption* toAXListBoxOption(const AXObject* object)
-{
-    ASSERT_WITH_SECURITY_IMPLICATION(!object || object->isListBoxOption());
-    return static_cast<const AXListBoxOption*>(object);
-}
-
-// This will catch anyone doing an unnecessary cast.
-void toAXListBoxOption(const AXListBoxOption*);
+DEFINE_AX_OBJECT_TYPE_CASTS(AXListBoxOption, isListBoxOption());

[r.kasibhatla, 2013/10/21 12:28:31]

Wouldn't it be better to construct even isFoo from object type, something like 
DEFINE_TYPE_CASTS(thisType, AXObject, object, object->is##AXObject(),
object.is##AXObject())

1. It would really simplify the usage for devs - just define the macro passing
classname.
2. There would be consistency even in naming of isFoo() calls - just like
toFoo()
3. It would make regex matching in style-checker efficient - what to exactly
look out for.

[tkent, 2013/10/21 22:06:11]

We should go ahead with this CL as is, and discuss this separately.
This issue affects whole the code, and we need to discuss it in blink-dev.

IMO, renaming AXObject::isFoo to AXObject::isAXFoo looks redundant. We already
have AX prefix in the class name.

 
 } // namespace WebCore
 
 #endif // AXListBoxOption_h