Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(841)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 314603006: DevTools: Parallel DiscoveryRequest (Closed)

Created:
6 years, 6 months ago by vkuzkokov
Modified:
6 years, 6 months ago
CC:
chromium-reviews, vsevik, yurys, paulirish+reviews_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Unneeded DevToolsAndroidBridge:: #

Patch Set 3 : Rebased #

Patch Set 4 : Returned forced destruction on UI for DiscoveryRequest #

Patch Set 5 : Fixed MockAdbServer to support multiple connections #

Patch Set 6 : Increased backlog for MockAdbServer #

Unified diffs Side-by-side diffs Delta from patch set Stats (+166 lines, -225 lines) Patch
M chrome/browser/devtools/device/adb/mock_adb_server.cc View 1 2 3 4 5 10 chunks +112 lines, -129 lines 0 comments Download
M chrome/browser/devtools/device/devtools_android_bridge.cc View 1 2 3 2 chunks +54 lines, -96 lines 0 comments Download

Messages

Total messages: 18 (0 generated)
vkuzkokov
6 years, 6 months ago (2014-06-03 15:01:36 UTC) #1
Vladislav Kaznacheev
lgtm
6 years, 6 months ago (2014-06-04 13:10:55 UTC) #2
vkuzkokov
The CQ bit was checked by vkuzkokov@chromium.org
6 years, 6 months ago (2014-06-04 13:15:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vkuzkokov@chromium.org/314603006/40001
6 years, 6 months ago (2014-06-04 13:17:14 UTC) #4
vkuzkokov
The CQ bit was unchecked by vkuzkokov@chromium.org
6 years, 6 months ago (2014-06-04 16:56:44 UTC) #5
vkuzkokov
The CQ bit was checked by vkuzkokov@chromium.org
6 years, 6 months ago (2014-06-04 17:01:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vkuzkokov@chromium.org/314603006/60001
6 years, 6 months ago (2014-06-04 17:03:20 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-04 22:42:14 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-04 22:45:55 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_compile_rel/builds/10621)
6 years, 6 months ago (2014-06-04 22:45:56 UTC) #10
vkuzkokov
The CQ bit was checked by vkuzkokov@chromium.org
6 years, 6 months ago (2014-06-05 15:49:46 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vkuzkokov@chromium.org/314603006/80001
6 years, 6 months ago (2014-06-05 15:51:00 UTC) #12
commit-bot: I haz the power
Change committed as 275206
6 years, 6 months ago (2014-06-05 19:00:28 UTC) #13
Vladislav Kaznacheev
lgtm
6 years, 6 months ago (2014-06-06 10:00:25 UTC) #14
vkuzkokov
On 2014/06/06 10:00:25, Vladislav Kaznacheev wrote: > lgtm I doubt that it will work: the ...
6 years, 6 months ago (2014-06-06 10:04:17 UTC) #15
vkuzkokov
The CQ bit was checked by vkuzkokov@chromium.org
6 years, 6 months ago (2014-06-06 12:35:09 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vkuzkokov@chromium.org/314603006/100001
6 years, 6 months ago (2014-06-06 12:35:50 UTC) #17
commit-bot: I haz the power
6 years, 6 months ago (2014-06-06 16:49:52 UTC) #18
Message was sent while issue was closed. 
Change committed as 275459

Powered by Google App Engine
This is Rietveld 408576698