Parser: Delay internalizing strings and values.

src/prettyprinter.h

Index: src/prettyprinter.h
diff --git a/src/prettyprinter.h b/src/prettyprinter.h
index e0467ca82aed348248e58351ca8b0da01a23d125..75ce1fe9b1cb68f78a8aa93c4832751d9e34facc 100644
--- a/src/prettyprinter.h
+++ b/src/prettyprinter.h
@@ -44,9 +44,10 @@ class PrettyPrinter: public AstVisitor {
   const char* Output() const { return output_; }
 
   virtual void PrintStatements(ZoneList<Statement*>* statements);
-  void PrintLabels(ZoneStringList* labels);
+  void PrintLabels(ZoneList<const AstString*>* labels);
   virtual void PrintArguments(ZoneList<Expression*>* arguments);
   void PrintLiteral(Handle<Object> value, bool quote);

[rossberg, 2014/06/11 14:58:13]

Maybe unify these two into one PrintValue(AstValue*)?

[marja, 2014/06/12 09:57:54]

I can't, since not all the strings to be printed are inside AstValues. For
example node->proxy()->name() is an AstString*, a label is an AstString*.

What I could do is to change the one that takes Handle<Object> value to take an
AstValue* and dispatch based on its type, but that's a bit unnecessary change.

+  void PrintLiteral(const AstString* value, bool quote);
   void PrintParameters(Scope* scope);
   void PrintDeclarations(ZoneList<Declaration*>* declarations);
   void PrintFunctionLiteral(FunctionLiteral* function);
@@ -83,7 +84,7 @@ class AstPrinter: public PrettyPrinter {
   void PrintLiteralWithModeIndented(const char* info,
                                     Variable* var,
                                     Handle<Object> value);
-  void PrintLabelsIndented(ZoneStringList* labels);
+  void PrintLabelsIndented(ZoneList<const AstString*>* labels);
 
   void inc_indent() { indent_++; }
   void dec_indent() { indent_--; }