Parser: Delay internalizing strings and values.

tools/parser-shell.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 26 matching lines @@
 #include "src/compiler.h"
 #include "src/scanner-character-streams.h"
 #include "tools/shell-utils.h"
 #include "src/parser.h"
 #include "src/preparse-data-format.h"
 #include "src/preparse-data.h"
 #include "src/preparser.h"
 
 using namespace v8::internal;
 
+class StringResource8 : public v8::String::ExternalAsciiStringResource {
+ public:
+  StringResource8(const char* data, int length)
+      : data_(data), length_(length) { }
+  virtual size_t length() const { return length_; }
+  virtual const char* data() const { return data_; }
+
+ private:
+  const char* data_;
+  int length_;
+};
+
 std::pair<TimeDelta, TimeDelta> RunBaselineParser(
     const char* fname, Encoding encoding, int repeat, v8::Isolate* isolate,
     v8::Handle<v8::Context> context) {
   int length = 0;
   const byte* source = ReadFileAndRepeat(fname, &length, repeat);
   v8::Handle<v8::String> source_handle;
   switch (encoding) {
     case UTF8: {
       source_handle = v8::String::NewFromUtf8(
           isolate, reinterpret_cast<const char*>(source));
       break;
     }
     case UTF16: {
       source_handle = v8::String::NewFromTwoByte(
           isolate, reinterpret_cast<const uint16_t*>(source),
           v8::String::kNormalString, length / 2);
       break;
     }
     case LATIN1: {
-      source_handle = v8::String::NewFromOneByte(isolate, source);
+      StringResource8* string_resource =
+          new StringResource8(reinterpret_cast<const char*>(source), length);
+      source_handle = v8::String::NewExternal(isolate, string_resource);
       break;
     }
   }
   TimeDelta parse_time1, parse_time2;
   Handle<Script> script = Isolate::Current()->factory()->NewScript(
       v8::Utils::OpenHandle(*source_handle));
   i::ScriptData* cached_data_impl = NULL;
   // First round of parsing (produce data to cache).
   {
     CompilationInfoWithZone info(script);
@@ skipping 71 matching lines @@
       if (benchmark.empty()) benchmark = "Baseline";
       printf("%s(FirstParseRunTime): %.f ms\n", benchmark.c_str(),
              first_parse_total);
       printf("%s(SecondParseRunTime): %.f ms\n", benchmark.c_str(),
              second_parse_total);
     }
   }
   v8::V8::Dispose();
   return 0;
 }