Issue 3146025: set_chronos_password.sh: Add missing sudo while grepping the contents of shadow on root fs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3146025: set_chronos_password.sh: Add missing sudo while grepping the contents of shadow on root fs. (Closed)

Created:
10 years, 4 months ago by gauravsh

Modified:
9 years, 6 months ago

Reviewers:
petkov

CC:
chromium-os-reviews_chromium.org, Randall Spangler, gauravsh, Luigi Semenzato, Bill Richardson

Base URL:
http://src.chromium.org/git/vboot_reference.git

Visibility:
Public.

Description

set_chronos_password.sh: Add missing sudo while grepping the contents of shadow on root fs. BUG=none TEST=manual Change-Id: Ie0d237c0dc6a2c45ffc33b2fcc22279127854ed9

Patch Set 1 #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	scripts/image_signing/set_chronos_password.sh	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

petkov

LGTM although -- that file path seemed to be word-readable and everything worked fine for ...

10 years, 4 months ago (2010-08-20 04:18:39 UTC) #2

gauravsh

10 years, 4 months ago (2010-08-20 19:22:25 UTC) #3

On Thu, Aug 19, 2010 at 9:18 PM,  <petkov@chromium.org> wrote:
> LGTM although -- that file path seemed to be word-readable and everything
> worked
> fine for me (and sumit) without sudo. Are you sure there isn't something
> else
> going on?

Unsure. Everytime I ran the script - it complained with a permission
denied error. A sudo on the grep fixed the problem (so did running
set_chronos_password.sh with a sudo). I had the same problem with
multiple images.

>
>
> http://codereview.chromium.org/3146025/show
>

-- 
-g

Expand Messages | Collapse Messages