media/cast/transport/utility/transport_encryption_handler.h - Issue 314593002: [Cast] Cleanup: Remove TransportXXXXXSender, an unnecessary layer of indirection.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/cast/transport/utility/transport_encryption_handler.h

Issue 314593002: [Cast] Cleanup: Remove TransportXXXXXSender, an unnecessary layer of indirection. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Move encryption into CastTransportSenderImpl so it happens in the browser process. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: media/cast/transport/utility/transport_encryption_handler.h

diff --git a/media/cast/transport/utility/transport_encryption_handler.h b/media/cast/transport/utility/transport_encryption_handler.h

index dd740be2077dca7f50edfc03d7d068bcd04a6bce..06d0e3f34d61fc18efd9489d130510c0c46b8cc8 100644

--- a/media/cast/transport/utility/transport_encryption_handler.h

+++ b/media/cast/transport/utility/transport_encryption_handler.h

@@ -37,6 +37,9 @@ class TransportEncryptionHandler : public base::NonThreadSafe {

const base::StringPiece& ciphertext,

std::string* plaintext);

+ // TODO(miu): This naming is very misleading. It should be called

+ // is_activated() since Initialize() without keys (i.e., cypto is disabled)

+ // may have succeeded.

bool initialized() const { return initialized_; }

private:

« media/cast/transport/cast_transport_sender.h ('K') | « media/cast/transport/transport_video_sender.cc ('k') | media/cast/video_sender/video_sender.h » ('j') | no next file with comments »