Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Side by Side Diff: media/cast/transport/cast_transport_sender_impl.h

Issue 314593002: [Cast] Cleanup: Remove TransportXXXXXSender, an unnecessary layer of indirection. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Restored/Improved CastSenderImpl VLOGging. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef MEDIA_CAST_TRANSPORT_CAST_TRANSPORT_IMPL_H_ 5 #ifndef MEDIA_CAST_TRANSPORT_CAST_TRANSPORT_IMPL_H_
6 #define MEDIA_CAST_TRANSPORT_CAST_TRANSPORT_IMPL_H_ 6 #define MEDIA_CAST_TRANSPORT_CAST_TRANSPORT_IMPL_H_
7 7
8 #include "base/callback.h" 8 #include "base/callback.h"
9 #include "base/memory/ref_counted.h" 9 #include "base/memory/ref_counted.h"
10 #include "base/memory/scoped_ptr.h" 10 #include "base/memory/scoped_ptr.h"
11 #include "base/time/tick_clock.h" 11 #include "base/time/tick_clock.h"
12 #include "base/time/time.h" 12 #include "base/time/time.h"
13 #include "base/timer/timer.h" 13 #include "base/timer/timer.h"
14 #include "media/cast/logging/logging_defines.h" 14 #include "media/cast/logging/logging_defines.h"
15 #include "media/cast/logging/simple_event_subscriber.h" 15 #include "media/cast/logging/simple_event_subscriber.h"
16 #include "media/cast/transport/cast_transport_config.h" 16 #include "media/cast/transport/cast_transport_config.h"
17 #include "media/cast/transport/cast_transport_sender.h" 17 #include "media/cast/transport/cast_transport_sender.h"
18 #include "media/cast/transport/pacing/paced_sender.h" 18 #include "media/cast/transport/pacing/paced_sender.h"
19 #include "media/cast/transport/rtcp/rtcp_builder.h" 19 #include "media/cast/transport/rtcp/rtcp_builder.h"
20 #include "media/cast/transport/transport_audio_sender.h" 20 #include "media/cast/transport/rtp_sender/rtp_sender.h"
21 #include "media/cast/transport/transport_video_sender.h"
22 21
23 namespace media { 22 namespace media {
24 namespace cast { 23 namespace cast {
25 namespace transport { 24 namespace transport {
26 25
27 class CastTransportSenderImpl : public CastTransportSender { 26 class CastTransportSenderImpl : public CastTransportSender {
28 public: 27 public:
29 // external_transport is only used for testing. 28 // external_transport is only used for testing.
30 // Note that SetPacketReceiver does not work if an external 29 // Note that SetPacketReceiver does not work if an external
31 // transport is provided. 30 // transport is provided.
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
75 void SendRawEvents(); 74 void SendRawEvents();
76 75
77 base::TickClock* clock_; // Not owned by this class. 76 base::TickClock* clock_; // Not owned by this class.
78 CastTransportStatusCallback status_callback_; 77 CastTransportStatusCallback status_callback_;
79 scoped_refptr<base::SingleThreadTaskRunner> transport_task_runner_; 78 scoped_refptr<base::SingleThreadTaskRunner> transport_task_runner_;
80 79
81 scoped_ptr<UdpTransport> transport_; 80 scoped_ptr<UdpTransport> transport_;
82 LoggingImpl logging_; 81 LoggingImpl logging_;
83 PacedSender pacer_; 82 PacedSender pacer_;
84 RtcpBuilder rtcp_builder_; 83 RtcpBuilder rtcp_builder_;
85 scoped_ptr<TransportAudioSender> audio_sender_; 84 scoped_ptr<RtpSender> audio_sender_;
86 scoped_ptr<TransportVideoSender> video_sender_; 85 scoped_ptr<RtpSender> video_sender_;
87 86
88 // This is non-null iff |raw_events_callback_| is non-null. 87 // This is non-null iff |raw_events_callback_| is non-null.
89 scoped_ptr<SimpleEventSubscriber> event_subscriber_; 88 scoped_ptr<SimpleEventSubscriber> event_subscriber_;
90 base::RepeatingTimer<CastTransportSenderImpl> raw_events_timer_; 89 base::RepeatingTimer<CastTransportSenderImpl> raw_events_timer_;
91 90
92 BulkRawEventsCallback raw_events_callback_; 91 BulkRawEventsCallback raw_events_callback_;
93 92
94 DISALLOW_COPY_AND_ASSIGN(CastTransportSenderImpl); 93 DISALLOW_COPY_AND_ASSIGN(CastTransportSenderImpl);
95 }; 94 };
96 95
97 } // namespace transport 96 } // namespace transport
98 } // namespace cast 97 } // namespace cast
99 } // namespace media 98 } // namespace media
100 99
101 #endif // MEDIA_CAST_TRANSPORT_CAST_TRANSPORT_IMPL_H_ 100 #endif // MEDIA_CAST_TRANSPORT_CAST_TRANSPORT_IMPL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698