[Cast] Cleanup: Remove TransportXXXXXSender, an unnecessary layer of indirection.

[Cast] Cleanup: Remove TransportXXXXXSender, an unnecessary layer of indirection.

In src/media/cast/transport, both TransportAudioSender and
TransportVideoSender were identical classes/implementations.  In
addition, they did nothing but wrap RtpSender, passing EncodedFrame data
through the encryption library.  Instead of merging them into one class,
both have been deleted, with the encryption calls moved into
AudioSender/VideoSender.

Testing: Confirmed all unit tests continue to pass.  Also, manually
tested with a browser build, with DVLOG output to confirm encryption
was successfully enabled for a cast session.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274769

[miu, 2014-06-03 05:27:15]

hubbe: PTAL.

[Alpha Left Google, 2014-06-03 18:48:34]

Thanks! This is a longer needed cleanup.

https://codereview.chromium.org/314593002/diff/20001/media/cast/cast_sender_i...
File media/cast/cast_sender_impl.cc (left):

https://codereview.chromium.org/314593002/diff/20001/media/cast/cast_sender_i...
media/cast/cast_sender_impl.cc:121: VLOG(1) << "CastSender::ctor";
Hey please don't remove this. It's useful for debugging. Or removing the logging
for dtor as well.

[miu, 2014-06-03 19:57:50]

Thanks for the review Alpha.  Addressed your comment:

https://codereview.chromium.org/314593002/diff/20001/media/cast/cast_sender_i...
File media/cast/cast_sender_impl.cc (left):

https://codereview.chromium.org/314593002/diff/20001/media/cast/cast_sender_i...
media/cast/cast_sender_impl.cc:121: VLOG(1) << "CastSender::ctor";
On 2014/06/03 18:48:35, Alpha wrote:
> Hey please don't remove this. It's useful for debugging. Or removing the
logging
> for dtor as well.

Done.  I also "improved" all the VLOGs so that one can differentiate logging
from the audio sender vs video sender.

[Alpha Left Google, 2014-06-03 20:01:52]

https://codereview.chromium.org/314593002/diff/40001/media/cast/audio_sender/...
File media/cast/audio_sender/audio_sender.h (right):

https://codereview.chromium.org/314593002/diff/40001/media/cast/audio_sender/...
media/cast/audio_sender/audio_sender.h:73: transport::TransportEncryptionHandler
encryptor_;
It is by design to have encryption done in the transport layer for security
reason.

https://codereview.chromium.org/314593002/diff/40001/media/cast/video_sender/...
File media/cast/video_sender/video_sender.h (right):

https://codereview.chromium.org/314593002/diff/40001/media/cast/video_sender/...
media/cast/video_sender/video_sender.h:135:
transport::TransportEncryptionHandler encryptor_;
Same here. It is by design to perform encryption in the browser process. We
eventually want all outgoing traffic to be encrypted in the browser process.

[miu, 2014-06-03 21:55:15]

Moved encryption back into browser process.  PTAL.

https://codereview.chromium.org/314593002/diff/40001/media/cast/audio_sender/...
File media/cast/audio_sender/audio_sender.h (right):

https://codereview.chromium.org/314593002/diff/40001/media/cast/audio_sender/...
media/cast/audio_sender/audio_sender.h:73: transport::TransportEncryptionHandler
encryptor_;
On 2014/06/03 20:01:52, Alpha wrote:
> It is by design to have encryption done in the transport layer for security
> reason.

Done.

https://codereview.chromium.org/314593002/diff/40001/media/cast/video_sender/...
File media/cast/video_sender/video_sender.h (right):

https://codereview.chromium.org/314593002/diff/40001/media/cast/video_sender/...
media/cast/video_sender/video_sender.h:135:
transport::TransportEncryptionHandler encryptor_;
On 2014/06/03 20:01:52, Alpha wrote:
> Same here. It is by design to perform encryption in the browser process. We
> eventually want all outgoing traffic to be encrypted in the browser process.

Done.

[hubbe, 2014-06-03 22:42:22]

https://codereview.chromium.org/314593002/diff/60001/media/cast/transport/cas...
File media/cast/transport/cast_transport_sender.h (right):

https://codereview.chromium.org/314593002/diff/60001/media/cast/transport/cas...
media/cast/transport/cast_transport_sender.h:80: virtual void
InsertCodedAudioFrame(const EncodedFrame& audio_frame) = 0;
How about replacing these two functions with
InsertCodedFrame(const EncodedFrame& frame, int ssrc) = 0;
?

[miu, 2014-06-03 23:32:56]

https://codereview.chromium.org/314593002/diff/60001/media/cast/transport/cas...
File media/cast/transport/cast_transport_sender.h (right):

https://codereview.chromium.org/314593002/diff/60001/media/cast/transport/cas...
media/cast/transport/cast_transport_sender.h:80: virtual void
InsertCodedAudioFrame(const EncodedFrame& audio_frame) = 0;
On 2014/06/03 22:42:22, hubbe wrote:
> How about replacing these two functions with
> InsertCodedFrame(const EncodedFrame& frame, int ssrc) = 0;
> ?

Good idea, but I'd like to reserve this for a later change.  Changing this
interface means doing a bunch of work in each subclass.

[Alpha Left Google, 2014-06-03 23:33:56]

lgtm

[miu, 2014-06-03 23:58:52]

The CQ bit was checked by miu@chromium.org

[commit-bot: I haz the power, 2014-06-04 00:00:20]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/miu@chromium.org/314593002/80001

[miu, 2014-06-04 04:04:48]

The CQ bit was unchecked by miu@chromium.org

[miu, 2014-06-04 04:28:31]

The CQ bit was checked by miu@chromium.org

[commit-bot: I haz the power, 2014-06-04 04:30:03]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/miu@chromium.org/314593002/100001

[commit-bot: I haz the power, 2014-06-04 06:21:17]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[commit-bot: I haz the power, 2014-06-04 11:19:25]

Change committed as 274769